Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/cel: fix handling of infinite values in rates #39940

Merged
merged 1 commit into from
Jun 20, 2024
Merged

x-pack/filebeat/input/cel: fix handling of infinite values in rates #39940

merged 1 commit into from
Jun 20, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 19, 2024 •
edited
Loading

Proposed commit message

The protobuf.Value.AsInterface method encodes +Inf as "Infinity" so ensure that we accept that string.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added Filebeat Filebeat bugfix Team:Security-Service Integrations Security Service Integrations Team backport-v8.14.0 Automated backport with mergify labels Jun 19, 2024
@efd6 efd6 self-assigned this Jun 19, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 19, 2024
@efd6
x-pack/filebeat/input/cel: fix handling of infinite values in rates
3d6ec8c 
The protobuf.Value.AsInterface method encodes +Inf as "Infinity" so
ensure that we accept that string.
@efd6 efd6 marked this pull request as ready for review June 19, 2024 09:04
@efd6 efd6 requested a review from a team as a code owner June 19, 2024 09:04
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

chrisberkhout
chrisberkhout approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@efd6 efd6 merged commit 1f8ad02 into elastic:main Jun 20, 2024
16 of 19 checks passed
mergify bot pushed a commit that referenced this pull request Jun 20, 2024
@efd6 @mergify
x-pack/filebeat/input/cel: fix handling of infinite values in rates (#…
70710f9 
…39940)

The protobuf.Value.AsInterface method encodes +Inf as "Infinity" so
ensure that we accept that string.

(cherry picked from commit 1f8ad02)
@mergify mergify bot mentioned this pull request Jun 20, 2024
Merged
6 tasks
efd6 added a commit that referenced this pull request Jun 20, 2024
@mergify @efd6
[8.14](backport #39940) x-pack/filebeat/input/cel: fix handling of in…
99a6e8c 
…finite values in rates (#39986)

* x-pack/filebeat/input/cel: fix handling of infinite values in rates (#39940)

The protobuf.Value.AsInterface method encodes +Inf as "Infinity" so
ensure that we accept that string.

(cherry picked from commit 1f8ad02)

* remove irrelevant changelog entry

---------

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisberkhout chrisberkhout chrisberkhout approved these changes

Assignees

@efd6 efd6

Labels
backport-v8.14.0 Automated backport with mergify bugfix Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@efd6 @elasticmachine @chrisberkhout