New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding goimports support to make check and fmt #4114

Merged
merged 1 commit into from Apr 26, 2017

Conversation

Projects
None yet
3 participants
@vjsamuel
Contributor

vjsamuel commented Apr 26, 2017

No description provided.

@elasticmachine

This comment has been minimized.

elasticmachine commented Apr 26, 2017

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticmachine

This comment has been minimized.

elasticmachine commented Apr 26, 2017

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@ruflin

+1 on adding goimports as it is also what I use in my editor. Lets see what CI thinks.

gofmt -s -l -w ${GOFILES_NOVENDOR}
goimports -l -w ${GOFILES_NOVENDOR}

This comment has been minimized.

@ruflin

ruflin Apr 26, 2017

Collaborator

I think goimports also does gofmt so we could remove gofmt.

This comment has been minimized.

@vjsamuel

vjsamuel Apr 26, 2017

Contributor

removed gofmt.

@@ -4,6 +4,7 @@ import (
"strings"

This comment has been minimized.

@ruflin

ruflin Apr 26, 2017

Collaborator

You missed the newline here ;-)

This comment has been minimized.

@vjsamuel

vjsamuel Apr 26, 2017

Contributor

done :) event goimports doesnt seem fool proof.

@ruflin ruflin merged commit a279b5d into elastic:master Apr 26, 2017

5 checks passed

CLA Commit author has signed the CLA
Details
codecov/patch Coverage not affected when comparing dce6887...f8113d4
Details
codecov/project 64.72% (+0.04%) compared to dce6887
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vjsamuel vjsamuel deleted the vjsamuel:goimports_check branch Apr 27, 2017

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment