Adding goimports support to make check and fmt #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjsamuel
force-pushed
the
goimports_check
branch
from
bf6c5ce
to
c6cfbb9
Compare
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
ruflin
reviewed
Apr 26, 2017
libbeat/scripts/Makefile
Outdated
| gofmt -s -l -w ${GOFILES_NOVENDOR} | ||
| goimports -l -w ${GOFILES_NOVENDOR} |
There was a problem hiding this comment.
I think goimports also does gofmt so we could remove gofmt.
| @@ -4,6 +4,7 @@ import ( | |||
| "strings" | |||
|
|
|||
There was a problem hiding this comment.
done :) event goimports doesnt seem fool proof.
vjsamuel
force-pushed
the
goimports_check
branch
from
c6cfbb9
to
f8113d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.