Filebeat Redis module #4441
Merged
Filebeat Redis module #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
added
Filebeat
tsg
force-pushed
the
filebeat_redis_module
branch
2 times, most recently
from
54980ff
to
b781250
Compare
|
Sample dashboard:
|
tsg
force-pushed
the
filebeat_redis_module
branch
2 times, most recently
from
ba7f73b
to
9e5c298
Compare
ruflin
reviewed
Jun 2, 2017
| "beat": common.MapStr{ | ||
| "read_timestamp": common.Time(time.Now()), | ||
| }, | ||
| "read_timestamp": common.Time(time.Now()), |
There was a problem hiding this comment.
That means read_timestamp is now a "common" global field in filebeat?
There was a problem hiding this comment.
Yeah, that's how it is since we introduced the modules. We can still change it for 6.0..
There was a problem hiding this comment.
Yeah, now I remember we even had a quick discussion. +1 on changing it but not sure what to :-)
|
LGTM, please address |
tsg
force-pushed
the
filebeat_redis_module
branch
from
9e5c298
to
6f0ca38
Compare
Contains two filesets: * One for collecting & parsing the logs written on disk by Redis * One that uses the Redis prospector to interrogate the slow logs This also moves beat.read_timestamp to read_timestamp to match the rest of the modules.
tsg
force-pushed
the
filebeat_redis_module
branch
from
6f0ca38
to
c1d41d4
Compare
|
Remaining test failures don't look related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains two filesets:
TODOs:
This also moves
beat.read_timestamptoread_timestampto match the rest of the modules.