Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting started #5326

Merged
merged 4 commits into from
Oct 31, 2017
Merged

Fix getting started #5326

merged 4 commits into from
Oct 31, 2017

Conversation

dedemorton
Copy link
Contributor

Fixes #5083 and #4391, plus a handful of nits that have bothering me.

tsg
tsg approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh
Copy link
Member

jenkins, test it

@andrewkroh andrewkroh merged commit fe57610 into elastic:master Oct 31, 2017
@dedemorton dedemorton added the needs_backport PR is waiting to be backported to other branches. label Oct 31, 2017
@dedemorton dedemorton mentioned this pull request Nov 1, 2017
Closed
dedemorton added a commit to dedemorton/beats that referenced this pull request Nov 7, 2017
@dedemorton
Fix getting started (elastic#5326)
be313e4 
* Move sentence to correct location

* Adds warning about deleting the index (fixes elastic#5083)

* Clarify settings for JSON parsing (fixes elastic#4391)

* Fix misc issues
dedemorton added a commit to dedemorton/beats that referenced this pull request Nov 14, 2017
@dedemorton
Fix getting started (elastic#5326)
7a4b171 
* Move sentence to correct location

* Adds warning about deleting the index (fixes elastic#5083)

* Clarify settings for JSON parsing (fixes elastic#4391)

* Fix misc issues
@dedemorton dedemorton mentioned this pull request Nov 14, 2017
Merged
ruflin pushed a commit that referenced this pull request Nov 14, 2017
@dedemorton @ruflin
Backport to 6.0: Fix getting started (#5326) (#5573)
487178f 
* Fix getting started (#5326)

* Move sentence to correct location

* Adds warning about deleting the index (fixes #5083)

* Clarify settings for JSON parsing (fixes #4391)

* Fix misc issues
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Nov 14, 2017
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@dedemorton @ruflin
Backport to 6.0: Fix getting started (elastic#5326) (elastic#5573)
fa77513 
* Fix getting started (elastic#5326)

* Move sentence to correct location

* Adds warning about deleting the index (fixes elastic#5083)

* Clarify settings for JSON parsing (fixes elastic#4391)

* Fix misc issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsg tsg tsg approved these changes

Assignees
No one assigned
Labels
docs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dedemorton @andrewkroh @tsg