Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SPDX licenses identifiers in CSV dependency file #5733

Merged
merged 2 commits into from
Nov 29, 2017
Merged

Use SPDX licenses identifiers in CSV dependency file #5733

merged 2 commits into from
Nov 29, 2017

Conversation

mgreau
Copy link
Member

@mgreau mgreau commented Nov 28, 2017

This commit updates the generate_notice.py script to:

  • use SPDX licenses identifiers from https://spdx.org/licenses/ to identify license of 3rd party
    dependencies
  • use UNKNOWN keyword if the license cannot be identified
  • add titles to identify more licenses types:
    • LGPL-3.0
    • CC-BY-SA-4.0

With this PR there is no more UNKNOWN license (github.com/opencontainers/go-digest and github.com/juju/ratelimit are now identified).

@mgreau mgreau requested review from tsg and roncohen November 28, 2017 13:40
@ruflin
Copy link
Member

ruflin commented Nov 28, 2017

@mgreau Thanks for the PR. Could you rebase on master and run make update in the beats directory and push the updated NOTICE file? Like this our NOTICE file is updated with these changes and CI will be happy.

This commit updates the `generate_notice.py` script to:
* use SPDX licenses identifiers from https://spdx.org/licenses/ to identify license of 3rd party
dependencies
* use `UNKNOWN` keyword if the license cannot be identified
* add titles to identify more licenses types:
 * LGPL-3.0
 * CC-BY-SA-4.0
@mgreau
Copy link
Member Author

mgreau commented Nov 29, 2017

Thanks, @ruflin. I have updated the PR with the up-to-date NOTICE.txt file, the CI build still failed but I'm not sure it's related to this PR.

@ruflin ruflin merged commit 5118798 into elastic:master Nov 29, 2017
@ruflin
Copy link
Member

ruflin commented Nov 29, 2017

@mgreau Failures are not related but an issue we have with Jenkins. I merged the PR. Do we need to backport this to any branches?

@mgreau
Copy link
Member Author

mgreau commented Nov 29, 2017

@ruflin thanks for the merge. yes please backport it to 6.x 6.0 and 6.1 branches.

graphaelli added a commit to graphaelli/apm-server that referenced this pull request Nov 29, 2017
graphaelli added a commit to graphaelli/apm-server that referenced this pull request Nov 29, 2017
graphaelli added a commit to graphaelli/apm-server that referenced this pull request Nov 29, 2017
jalvz pushed a commit to elastic/apm-server that referenced this pull request Nov 29, 2017
* Use SPDX licenses identifiers in CSV dependency file

per elastic/beats#5733

* Update beats framework to e70be71
ruflin pushed a commit to ruflin/beats that referenced this pull request Nov 29, 2017
* Use SPDX licenses identifiers in CSV dependency file

This commit updates the `generate_notice.py` script to:
* use SPDX licenses identifiers from https://spdx.org/licenses/ to identify license of 3rd party
dependencies
* use `UNKNOWN` keyword if the license cannot be identified
* add titles to identify more licenses types:
 * LGPL-3.0
 * CC-BY-SA-4.0

* Update NOTICE.txt with SPDX identifiers

(cherry picked from commit 5118798)
ruflin pushed a commit to ruflin/beats that referenced this pull request Nov 30, 2017
* Use SPDX licenses identifiers in CSV dependency file

This commit updates the `generate_notice.py` script to:
* use SPDX licenses identifiers from https://spdx.org/licenses/ to identify license of 3rd party
dependencies
* use `UNKNOWN` keyword if the license cannot be identified
* add titles to identify more licenses types:
 * LGPL-3.0
 * CC-BY-SA-4.0

* Update NOTICE.txt with SPDX identifiers

(cherry picked from commit 5118798)
@ruflin
Copy link
Member

ruflin commented Nov 30, 2017

@mgreau I opened the backport PRs.

andrewkroh pushed a commit that referenced this pull request Nov 30, 2017
* Use SPDX licenses identifiers in CSV dependency file

This commit updates the `generate_notice.py` script to:
* use SPDX licenses identifiers from https://spdx.org/licenses/ to identify license of 3rd party
dependencies
* use `UNKNOWN` keyword if the license cannot be identified
* add titles to identify more licenses types:
 * LGPL-3.0
 * CC-BY-SA-4.0

* Update NOTICE.txt with SPDX identifiers

(cherry picked from commit 5118798)
andrewkroh pushed a commit that referenced this pull request Dec 11, 2017
* Use SPDX licenses identifiers in CSV dependency file

This commit updates the `generate_notice.py` script to:
* use SPDX licenses identifiers from https://spdx.org/licenses/ to identify license of 3rd party
dependencies
* use `UNKNOWN` keyword if the license cannot be identified
* add titles to identify more licenses types:
 * LGPL-3.0
 * CC-BY-SA-4.0

* Update NOTICE.txt with SPDX identifiers

(cherry picked from commit 5118798)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…lastic#5765)

* Use SPDX licenses identifiers in CSV dependency file

This commit updates the `generate_notice.py` script to:
* use SPDX licenses identifiers from https://spdx.org/licenses/ to identify license of 3rd party
dependencies
* use `UNKNOWN` keyword if the license cannot be identified
* add titles to identify more licenses types:
 * LGPL-3.0
 * CC-BY-SA-4.0

* Update NOTICE.txt with SPDX identifiers

(cherry picked from commit f117e5d)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…lastic#5763)

* Use SPDX licenses identifiers in CSV dependency file

This commit updates the `generate_notice.py` script to:
* use SPDX licenses identifiers from https://spdx.org/licenses/ to identify license of 3rd party
dependencies
* use `UNKNOWN` keyword if the license cannot be identified
* add titles to identify more licenses types:
 * LGPL-3.0
 * CC-BY-SA-4.0

* Update NOTICE.txt with SPDX identifiers

(cherry picked from commit f117e5d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants