Add a parameter to docker prospector to filter on stream
#6057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes you are only interested on stdout or stderr, this parameters allows to filter the input and only read one of them.
exekias
force-pushed
the
docker-filter-stream
branch
from
de2b159
to
e21a021
Compare
ruflin
reviewed
Jan 16, 2018
| return &DockerJSON{reader: r} | ||
| func NewDockerJSON(r Reader, stream string) *DockerJSON { | ||
| return &DockerJSON{ | ||
| stream: stream, |
There was a problem hiding this comment.
We should validate that it's a valid stream name.
| @@ -85,7 +85,7 @@ type config struct { | |||
| JSON *reader.JSONConfig `config:"json"` | |||
|
|
|||
| // Hidden on purpose, used by the docker prospector: | |||
| DockerJSON bool `config:"docker-json"` | |||
| DockerJSON string `config:"docker-json"` | |||
There was a problem hiding this comment.
What's the reason for this change?
There was a problem hiding this comment.
I'm using the internal parameter to enable docker parsing and pass the desired stream through it, possible values:
""- default, docker parsing is disabledall- default fordockerprospector, read all streamsstdoutstderr
There was a problem hiding this comment.
Got it, didn't realise you passed through the stream param.
|
Thank you for the review @ruflin, this should be ready for a second look 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you are only interested on stdout or stderr, this parameters
allows to filter the input and only read one of them: