Remove arch from test audit rules #6783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to the patch from https://github.com/linux-on-ibm-z/docs/wiki/Building-Beats. elastic/go-libaudit#23 should be merged first then I'll update the vendor.json with the actual commit ID. |
|
The referenced PR was merged. |
andrewkroh
force-pushed
the
bugfix/ab/s390-patch
branch
from
9e817c4
to
deb6a83
Compare
|
This is now updated with the latest go-libaudit release. |
|
@andrewkroh |
The audit rules in the tests contain "-F arch=b64" which makes them valid only for a few architectures ("aarch64", "x86_64", "ppc"). By removing the filter Auditbeat will automatically use the GOOS architecture in determining how to translate the syscall name to the appropriate syscall number (syscall numbers are architecture specific).
andrewkroh
force-pushed
the
bugfix/ab/s390-patch
branch
from
deb6a83
to
791e9a9
Compare
|
I updated the NOTICE and pushed an update. |
|
Changes lgtm, wfg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The audit rules in the tests contain "-F arch=b64" which makes them valid only for a few architectures ("aarch64", "x86_64", "ppc"). By removing the filter Auditbeat will automatically use the GOOS architecture in determining how to translate the syscall name to the appropriate syscall number (syscall numbers are architecture specific).