Better error handling in fsnotify recursive monitor #6949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the recursive `file_monitor` is scanning a directory, it will ignore paths that include an error. This is wrong, as sometimes those paths can still be processed. For example, a directory might not be readable, but the user wants to receive an event when it is created, even if its contents can't be known. This has been uncovered by recent changes in how directory errors are reported by `filepath.Walk`, introduced in Go 1.10. Previously `walkFn` would be called twice. Once without an error (when the directory has been found during scan of the parent directory), and the second time with an error (when access to the directory is attempted).
adriansr
force-pushed
the
fix/auditbeat_go1.10
branch
from
1f82968
to
4d9bcc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the recursive
file_monitoris scanning a directory, it will ignore paths that include an error. This is wrong, as sometimes those paths can still be processed. For example, a directory might not be readable, but the user wants to receive an event when it is created, even if its contents can't be known.This has been uncovered by recent changes in how directory errors are reported by
filepath.Walk, introduced in Go 1.10. PreviouslywalkFnwould be called twice. Once without an error (when the directory has been found during scan of the parent directory), and the second time with an error (when access to the directory is attempted).Fixes auditbeat test failure in #6948