Add Filebeat module to state API #7532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 6, 2018
filebeat/fileset/factory.go
Outdated
| for _, input := range p.inputs { | ||
| input.Stop() | ||
| } | ||
|
|
||
| // Loop through and remove modules, only 1 normally | ||
| for m, _ := range p.moduleRegistry.registry { |
There was a problem hiding this comment.
should omit 2nd value from range; this loop is equivalent to for m := range ...
filebeat/fileset/factory.go
Outdated
| @@ -127,13 +140,57 @@ func (p *inputsRunner) Start() { | |||
| for _, input := range p.inputs { | |||
| input.Start() | |||
| } | |||
|
|
|||
| // Loop through and add modules, only 1 normally | |||
| for m, _ := range p.moduleRegistry.registry { | |||
There was a problem hiding this comment.
should omit 2nd value from range; this loop is equivalent to for m := range ...
9 tasks
|
I created #7536 for the refactoring. |
ruflin
force-pushed
the
module-state
branch
2 times, most recently
from
0e18aae
to
9eb3f43
Compare
The document looks as following:
```
{
"module": {
"count": 1,
"names": ["redis"]
}
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The document looks as following: