Replace freeport with independent impl. #7853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
force-pushed
the
removefreeport
branch
from
814299c
to
ba36e4f
Compare
ruflin
reviewed
Aug 6, 2018
libbeat/testing/available_port.go
Outdated
|
|
||
| // AvailableTCPPort returns an unused TCP port for 127.0.0.1. | ||
| func AvailableTCPPort() (uint16, error) { | ||
| resolved, err := net.ResolveTCPAddr("ip4", "127.0.0.1:0") |
There was a problem hiding this comment.
Seems like this causes some troubles on CI.
andrewvc
force-pushed
the
removefreeport
branch
2 times, most recently
from
246cd2a
to
12f0f90
Compare
andrewkroh
reviewed
Aug 6, 2018
libbeat/testing/available_port.go
Outdated
| import "net" | ||
|
|
||
| // AvailableTCPPort returns an unused TCP port for 127.0.0.1. | ||
| func AvailableTCPPort() (uint16, error) { |
There was a problem hiding this comment.
Perhaps the name should include TCP4? You might want to add a TCP6 version in the future.
andrewvc
force-pushed
the
removefreeport
branch
from
12f0f90
to
4408580
Compare
andrewvc
force-pushed
the
removefreeport
branch
from
4408580
to
d68fecd
Compare
|
Thanks for the cleanup. |
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Aug 15, 2018
This removes a trivial dep I recently added and substitutes it for a small function.
ruflin
pushed a commit
that referenced
this pull request
Aug 16, 2018
This removes a trivial dep I recently added and substitutes it for a small function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a trivial dep I recently added and substitutes it for a small function.