check.response.body value must not be quoted #7936
Conversation
When checking the response body of an http request, the expected string must not be quoted. Otherwise the quotes are expected to be part of the response body.
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
| @@ -479,7 +479,7 @@ contains JSON: | |||
| 'X-API-Key': '12345-mykey-67890' | |||
| check.response: | |||
| status: 200 | |||
| body: '{"status": "ok"}' | |||
| body: {"status": "ok"} | |||
There was a problem hiding this comment.
The input is yaml. By using single quotes, the body will be parsed as a string. Single quotes will be removed, double quotes will be kept. By removing the single quotes, body is parsed as an object (with double quotes being removed). Checking the configuration object in heartbeat (has been changed recently), body must be a list of regular expressions:
body: ['{"status":\s*"ok"}']
Using \s+ we make whitepsace optional.
|
Should this PR be opened against master and then backported (if needed)? Will also need a changelog. |
|
#8667 will make this change unnecessary since we'll have a better mechanism for checking JSON. |
When checking the response body of an http request, the expected string must not be quoted. Otherwise the quotes are expected to be part of the response body.