Update Beats to use go 1.11.2 #8746
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
vjsamuel
force-pushed
the
beats-go11
branch
2 times, most recently
from
2580003
to
e273658
Compare
libbeat/plugin/cli.go
Outdated
| @@ -39,7 +39,7 @@ func (p *pluginList) String() string { | |||
| func (p *pluginList) Set(v string) error { | |||
| for _, path := range p.paths { | |||
| if path == v { | |||
| logp.Warn("%s is already a registered plugin") | |||
| logp.Warn("%s is already a registered plugin", pathautodiscover/appenders/config/config.go:69) | |||
There was a problem hiding this comment.
expected selector or type assertion, found 'go'
vjsamuel
force-pushed
the
beats-go11
branch
4 times, most recently
from
7ea5a09
to
fbf9151
Compare
auditbeat/magefile.go
Outdated
| @@ -20,7 +20,7 @@ | |||
| package main | |||
|
|
|||
| import ( | |||
| "context" | |||
| input/log/input.go:513 "context" | |||
There was a problem hiding this comment.
expected 'STRING', found '/' (and 10 more errors)
vjsamuel
force-pushed
the
beats-go11
branch
8 times, most recently
from
e015ecf
to
90a6568
Compare
|
One change worth mentioning here is that now MacOS 10.10 at least is required:
It's not a problem because our support matrix already has 10.13 in and for APM-server 10.12 : https://www.elastic.co/support/matrix @elastic/apm-server We should probably bring these number in sync. @elastic/beats Anyone seeing any blockers to jump to 1.11 on master? |
|
I do not see a blocker to move to 1.11.1, we might see a few hiccups in the tooling but that should not stop us to live on the newest version. |
|
@vjsamuel I am confused by the commits in that PR, I see a lot of log statement changes? |
|
Thanks @ruflin, I've requested that change to the compat matrix. |
|
@ph go 1.11 has enhanced This caused |
|
This actually uses go 1.11.1 for package builds too - the title of this change should be updated accordingly. Also, we'll need Otherwise, +1 to moving to 1.11.1 while it's early in our dev cycle. |
|
I have raised elastic/fsevents#4 to fix Auditbeat for OSX. I will update the vendor once it gets mreged. |
vjsamuel
force-pushed
the
beats-go11
branch
2 times, most recently
from
b6f38d8
to
f2821b4
Compare
|
@graphaelli i have moved all the containers to 1.11.1. I dont know repo has |
|
jenkins, test this |
|
Jenkins, please test this. |
|
jenkins, test this |
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
vjsamuel
force-pushed
the
beats-go11
branch
2 times, most recently
from
ce07966
to
f29a883
Compare
|
@vjsamuel can you please rebase? There are potential merge conflicts. I also have had some problems with mage recently when using go1.11.2 (using go1.10.3 did work). Problem was in 6.5 branch, but I'd like to be sure master works. |
|
Jenkins, please test this. |
|
Jenkins, test this! |
|
jenkins, test this |
libbeat/docs/version.asciidoc
Outdated
| :go-version: 1.10.3 | ||
| :release-state: prerelease | ||
| :go-version: 1.11.2 | ||
| :release-state: unreleased |
There was a problem hiding this comment.
This worries me. Why did this change? This line should be reverted.
There was a problem hiding this comment.
I guess rebase did opt for the old one. It must say prerelease
libbeat/docs/version.asciidoc
Outdated
| :go-version: 1.10.3 | ||
| :release-state: prerelease | ||
| :go-version: 1.11.2 | ||
| :release-state: unreleased |
There was a problem hiding this comment.
I guess rebase did opt for the old one. It must say prerelease
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
|
@elastic/beats @elastic/apm-server You should probably update your local environment. @vjsamuel Thanks for keep pushing this one. |
No description provided.