Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ssl_request_log in apache2 module #9833

Merged
merged 4 commits into from
Jan 2, 2019
Merged

Add support for ssl_request_log in apache2 module #9833

merged 4 commits into from
Jan 2, 2019

Conversation

kaiyan-sheng
Copy link
Contributor

This PR is to add a new line in grok pattern to support ssl_request_log.
This PR closes issue: #8088

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner December 28, 2018 23:10
@kaiyan-sheng kaiyan-sheng added Team:Integrations Label for the Integrations team Filebeat Filebeat module needs_backport PR is waiting to be backported to other branches. review labels Dec 28, 2018
ruflin
ruflin approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor suggestion to change the names.

@kaiyan-sheng kaiyan-sheng merged commit 033b021 into elastic:master Jan 2, 2019
@kaiyan-sheng kaiyan-sheng deleted the ssl_request_log branch January 2, 2019 15:02
kaiyan-sheng added a commit that referenced this pull request Jan 4, 2019
@kaiyan-sheng
Cherry-pick to 6.x: Add support for ssl_request_log in apache2 module (…
404c19e 
…#9833) (#9848)

* Add support for ssl_request_log in apache2 module (#9833)

* Add support for ssl_request_log in apache2 module

* Update changelog

* Rename ssl.cipher and ssl.protocol

(cherry picked from commit 033b021)

* Fix apache2.access.http_version

* Rename url.original to apache2.access.url
@kaiyan-sheng kaiyan-sheng removed the needs_backport PR is waiting to be backported to other branches. label Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@exekias exekias exekias approved these changes

Assignees
No one assigned
Labels
Filebeat Filebeat module review Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @ruflin @exekias