Allow for multiple user specified secure settings secrets #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the API for all three CRDs, Elasticsearch, Kibana and APM Server to accept multiple secret references instead of just one. This is to facilitate use cases where users want an easy way to source secure setting from various locations without aggregating them manually. Instead the operator aggregates the contents of all specified secrets into one new secret managed by ECK which will be mounted into the pods and the contents of which will be loaded into the respective keystores.
sebgl
approved these changes
Aug 26, 2019
| // | ||
| // Secure settings are provided by the user in the APM or Kibana Spec through a secret reference. | ||
| // Secure settings are provided by the user in the resource Spec through secret references. | ||
| // The user provicded secrets are then aggregated into a single secret. |
pebrc
added
>breaking
and removed
>enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1457
Allow for multiple user specified secure settings secrets
This changes the API for all three CRDs, Elasticsearch, Kibana and APM Server to
accept multiple secret references instead of just one. This is to facilitate use
cases where users want an easy way to source secure setting from various
locations without aggregating them manually.
Instead the operator aggregates the contents of all specified secrets into one
new secret managed by ECK which will be mounted into the pods and the contents
of which will be loaded into the respective keystores.
Minor Refactorings