Add validation for declared volume claim templates #4526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #4525
Adds a validation to check that declared volume claim templates are actually mounted in any of the containers. This validation does not apply if the user configures the documented default data volume
elasticsearch-data
for which ECK manages the volume mount.There is still a possibility for misconfiguration. As we are currently supporting custom volume mounts and custom
data.path
settings in Elasticsearch it is quite hard to fully validate the configuration. With the proposed validation it would still be possible for a user to configure a custom volume claim template, mount it in a side car and have no persistent Elasticsearch data volume. This could be addressed in two ways:data.path
has a volume mount