Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang to 1.19 #5939

Merged
merged 6 commits into from
Aug 11, 2022
Merged

Update golang to 1.19 #5939

merged 6 commits into from
Aug 11, 2022

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Aug 10, 2022

I changed my mind about continuing to delay the update of go module to 1.18 (#5884) and golang to 1.19 (#5920). I would not like us to accumulate tech debt by pushing the update.

Here are the changes made by this PR:

  • Update to docker.io/library/golang:1.19.0
  • Update module go to 1.19
  • Update golangci-lint to 1.48.0
  • Remove ifshort linter deprecated since golangci-lint v1.48.0
  • Protect from Potential Slowloris Attack by setting ReadHeaderTimeout
  • Refactor comments after running go fmt (1.19)

Two linters are disabled until generics are fully supported. I think it's acceptable.

WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649. 
WARN [linters context] wastedassign is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649. 

Replaces #5938 and #5919.

@thbkrkr thbkrkr added >renovate PRs created by or relating to Renovate v2.5.0 labels Aug 10, 2022
@thbkrkr thbkrkr requested a review from barkbay August 10, 2022 15:04
@thbkrkr
Copy link
Contributor Author

thbkrkr commented Aug 10, 2022

Build PR failure:

[2022-08-10T15:16:38.847Z] docker: Error response from daemon: Head "https://registry-1.docker.io/v2/garethr/kubeval/manifests/latest": Get "https://auth.docker.io/token?scope=repository%3Agarethr%2Fkubeval%3Apull&service=registry.docker.io": EOF.

Jenkins test this please again.

Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Thanks 🙇

@thbkrkr thbkrkr merged commit 1de061e into elastic:main Aug 11, 2022
@thbkrkr thbkrkr deleted the update-to-go-1.19 branch October 11, 2022 11:52
fantapsody pushed a commit to fantapsody/cloud-on-k8s that referenced this pull request Feb 7, 2023
- Update to docker.io/library/golang:1.19.0
- Update module go to 1.19
- Update golangci-lint to 1.48.0
- Remove ifshort linter deprecated since golangci-lint v1.48.0
- Protect from Potential Slowloris Attack by setting ReadHeaderTimeout
- Refactor comments after running go fmt (1.19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>renovate PRs created by or relating to Renovate v2.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants