Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module go to 1.18 #5884

Closed
wants to merge 1 commit into from
Closed

Update module go to 1.18 #5884

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 21, 2022

Mend Renovate

This PR contains the following updates:

Package Type Update Change
go (source) golang minor 1.17 -> 1.18

Release Notes

golang/go

v1.18.4

v1.18.3

v1.18.2

v1.18.1

v1.18.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the >renovate PRs created by or relating to Renovate label Jul 21, 2022
@thbkrkr thbkrkr self-assigned this Jul 26, 2022
@thbkrkr
Copy link
Contributor

thbkrkr commented Jul 26, 2022

golangci-lint isn't fully ready for go1.18 (see golangci/golangci-lint#2649). We have many false positives with the latest v1.45.2. Let's wait that it is fully supported.

> golangci-lint run

W ARN [linters context] bodyclose is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 
WARN [linters context] nilerr is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 
WARN [linters context] noctx is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 
WARN [linters context] tparallel is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.

pkg/controller/beat/auditbeat/auditbeat.go:28:55: d.Client undefined (type *Driver has no field or method Client) (typecheck)
	managedConfig, err := beatcommon.BuildKibanaConfig(d.Client, beatv1beta1.BeatKibanaAssociation{Beat: &d.Beat})
	                                                     ^
pkg/controller/beat/auditbeat/auditbeat.go:30:73: d.Status undefined (type *Driver has no field or method Status) (typecheck)
		return reconciler.NewResult(d.DriverParams.Context).WithError(err), d.Status
		                                                                      ^
pkg/controller/beat/filebeat/filebeat.go:28:55: d.Client undefined (type *Driver has no field or method Client) (typecheck)
	managedConfig, err := beatcommon.BuildKibanaConfig(d.Client, beatv1beta1.BeatKibanaAssociation{Beat: &d.Beat})
	                                                     ^
pkg/controller/beat/filebeat/filebeat.go:30:73: d.Status undefined (type *Driver has no field or method Status) (typecheck)
		return reconciler.NewResult(d.DriverParams.Context).WithError(err), d.Status
		                                                                      ^
pkg/controller/beat/metricbeat/metricbeat.go:28:55: d.Client undefined (type *Driver has no field or method Client) (typecheck)
	managedConfig, err := beatcommon.BuildKibanaConfig(d.Client, beatv1beta1.BeatKibanaAssociation{Beat: &d.Beat})
	                                                     ^
pkg/controller/beat/metricbeat/metricbeat.go:30:73: d.Status undefined (type *Driver has no field or method Status) (typecheck)
		return reconciler.NewResult(d.DriverParams.Context).WithError(err), d.Status
		                                                                      ^
pkg/controller/beat/packetbeat/packetbeat.go:28:55: d.Client undefined (type *Driver has no field or method Client) (typecheck)
	managedConfig, err := beatcommon.BuildKibanaConfig(d.Client, beatv1beta1.BeatKibanaAssociation{Beat: &d.Beat})
	                                                     ^
pkg/controller/beat/packetbeat/packetbeat.go:30:73: d.Status undefined (type *Driver has no field or method Status) (typecheck)
		return reconciler.NewResult(d.DriverParams.Context).WithError(err), d.Status
		                                                                      ^
test/e2e/test/agent/steps.go:31:3: missing type in composite literal (typecheck)
		{
		^
test/e2e/test/agent/steps.go:38:3: missing type in composite literal (typecheck)
		{
		^
test/e2e/test/agent/steps.go:51:3: missing type in composite literal (typecheck)
		{
		^
test/e2e/test/agent/steps.go:58:3: missing type in composite literal (typecheck)
		{
		^
test/e2e/test/agent/steps.go:114:3: missing type in composite literal (typecheck)
		{
		^
test/e2e/test/agent/steps.go:209:3: missing type in composite literal (typecheck)
		{
		^
test/e2e/test/agent/steps.go:10:2: "reflect" imported but not used (typecheck)
	"reflect"
	^
test/e2e/test/agent/steps.go:15:2: "k8s.io/api/core/v1" imported but not used as corev1 (typecheck)
	corev1 "k8s.io/api/core/v1"
	^
test/e2e/test/agent/steps.go:22:2: "github.com/elastic/cloud-on-k8s/v2/pkg/utils/pointer" imported but not used (typecheck)
	"github.com/elastic/cloud-on-k8s/v2/pkg/utils/pointer"
	^
test/e2e/test/agent/steps.go:23:2: "github.com/elastic/cloud-on-k8s/v2/test/e2e/cmd/run" imported but not used (typecheck)
	"github.com/elastic/cloud-on-k8s/v2/test/e2e/cmd/run"
	^
test/e2e/test/kibana/steps_creation.go:20:3: missing type in composite literal (typecheck)
		{
		^
test/e2e/test/kibana/steps_creation.go:26:3: missing type in composite literal (typecheck)
		{
		^
test/e2e/test/kibana/steps_deletion.go:22:3: missing type in composite literal (typecheck)
		{
		^
test/e2e/test/kibana/steps_deletion.go:34:3: missing type in composite literal (typecheck)
		{
		^
test/e2e/test/kibana/steps_deletion.go:50:3: missing type in composite literal (typecheck)
		{
		^
test/e2e/test/kibana/steps_deletion.go:56:3: missing type in composite literal (typecheck)
		{
		^
test/e2e/test/kibana/steps_mutation.go:29:3: missing type in composite literal (typecheck)
		{
		^
pkg/controller/elasticsearch/client/base.go:99:73: `(*baseClient).put` - `out` always receives `nil` (unparam)
func (c *baseClient) put(ctx context.Context, pathWithQuery string, in, out interface{}) error {
                                                                        ^

@thbkrkr thbkrkr closed this Jul 26, 2022
@renovate
Copy link
Contributor Author

renovate bot commented Jul 26, 2022

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will now ignore this update (1.18). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/go-1.x branch July 26, 2022 13:31
@thbkrkr thbkrkr mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>renovate PRs created by or relating to Renovate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant