Adding an exhaustive list of Helm chart values to eck-elasticsearch Helm chart #6336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to: elastic#6187 Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
naemono
added
>enhancement
pebrc
reviewed
Jan 24, 2023
How do you feel about me documenting the most commonly used/overridden options in the podtemplatespec? While also pointing to the documentation? |
thbkrkr
reviewed
Jan 25, 2023
Review comments. Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
|
@pebrc I've trimmed down the number of fields shown in the |
thbkrkr
reviewed
Jan 25, 2023
thbkrkr
reviewed
Jan 25, 2023
|
Could you merge |
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
pebrc
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
LGTM, I think we really have to fix the Helm versioning. I just bumped the charts for a change that introduced the version to the next minor and here we are doing it again but to a patch version. @thbkrkr you have to probably consolidate these version bumps before creating the next release branch.
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
thbkrkr
reviewed
Feb 6, 2023
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
thbkrkr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an exhaustive list of Helm chart values to the eck-elasticsearch Helm chart.
This expands the
podTemplatefield in the values file and includes all relevant options within thepodTemplatefield.relates to #6187