CloudFormation: Fix missing tags in cloud-security account #1415
Conversation
This is a temporary fix that tags required resources for the build to succeed. We can revert it after the QA cycle to find a more elegant solution.
orestisfl
requested review from
amirbenun,
oren-zohar,
gurevichdmitry,
moukoublen and
maxcold
📊 Allure Report - 💚 No failures were reported.
|
|
The change to Cloudformation looks good to me, but I don't know much about |
Yes, no worries, mostly just CCing you :) |
orestisfl
force-pushed
the
7832/cloudformation-missing-tags
branch
2 times, most recently
from
6cf123f
to
7e018db
Compare
There was a problem hiding this comment.
@orestisfl I'm unsure if it's a good idea to address this at the template level. Given that we're making these templates available for public use, it may not be appropriate to include data specific to our AWS cloud specifications.
|
@gurevichdmitry, agreed, that's why we can revert this after the QA cycle. However, a clean solution is not easily apparent right now:
We are also investigating if we can work-around the requirements in a different way in the meantime. |
This is a temporary fix that tags required resources for the build to succeed. We can revert it after the QA cycle to find a more elegant solution. (cherry picked from commit d4ad5d4)
…rity account (#1423) CloudFormation: Fix missing tags in cloud-security account (#1415) This is a temporary fix that tags required resources for the build to succeed. We can revert it after the QA cycle to find a more elegant solution. (cherry picked from commit d4ad5d4) Co-authored-by: Orestis Floros <orestis.floros@elastic.co>
CloudFormation: Fix missing tags in cloud-security account This is a temporary fix that tags required resources for the build to succeed. We can revert it after the QA cycle to find a more elegant solution. See elastic/cloudbeat#1415
…lastic#1415)" This reverts commit d4ad5d4.
…lastic#1519) Revert "CloudFormation: Fix missing tags in cloud-security account (elastic#1415)" This reverts commit d4ad5d4.
Summary of your changes
This is a temporary fix that tags required resources for the build to succeed. We can revert it after the QA cycle to find a more elegant solution.