Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Add Elastic-specific tags in CloudFormation #8226

Merged
merged 1 commit into from Oct 17, 2023

Conversation

orestisfl
Copy link
Contributor

Proposed commit message

CloudFormation: Fix missing tags in cloud-security account

This is a temporary fix that tags required resources for the build to succeed. We can revert it after the QA cycle to find a more elegant solution.

See elastic/cloudbeat#1415

@orestisfl orestisfl added bug Something isn't working Team:Cloud Security Label for the Cloud Security team technical-debt labels Oct 17, 2023
@orestisfl orestisfl self-assigned this Oct 17, 2023
@orestisfl orestisfl requested a review from a team as a code owner October 17, 2023 08:12
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-17T08:13:01.638+0000

  • Duration: 15 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👎 -50.0
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@orestisfl orestisfl merged commit 0f5d3e0 into elastic:main Oct 17, 2023
4 checks passed
@orestisfl orestisfl deleted the cf-fix-tags branch October 17, 2023 08:28
@elasticmachine
Copy link

Package cloud_security_posture - 1.6.3 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

orestisfl added a commit to orestisfl/integrations that referenced this pull request Oct 19, 2023
orestisfl added a commit that referenced this pull request Oct 19, 2023
CloudFormation: Use link parametrized only by version, removes the need to open a new PR for each change.

Additionally, fixes the tag issue for CNVM that was forgotten in #8226.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Cloud Security Label for the Cloud Security team technical-debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants