Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce event.flags #191

Open
ruflin opened this issue Nov 28, 2018 · 3 comments
Open

Introduce event.flags #191

ruflin opened this issue Nov 28, 2018 · 3 comments

Comments

@ruflin
Copy link
Member

ruflin commented Nov 28, 2018

events can go through multiple entities and processing stages. To indicate multiple processing stages in filebeat for log events we introduced log.flags elastic/beats#7991. Some example for these flags are truncated, multiline. I think this could be more generic on the ECS side that we have event.flags so it's possible to add flags that provide additional meta information event.

@ypid-geberit
Copy link
Contributor

I created #1379 to document the de facto standard and for me to have something that I can for now use at ECS level custom internally.

@ebeahan
Copy link
Member

ebeahan commented Jun 29, 2021

log.flags continues to be set by the line readers in Beats. Couple of examples:

https://github.com/elastic/beats/blob/master/libbeat/reader/multiline/message_buffer.go#L123
https://github.com/elastic/beats/blob/master/libbeat/reader/readfile/limit.go#L48

Since this mechanism is low-level and relates to the event's logging mechanism and not context around the event itself, I lean towards formalizing the existing log.flags field vs. introducing event.flags.

@ebeahan
Copy link
Member

ebeahan commented Jun 30, 2021

@kvch @urso Do you have any thoughts about formalizing the log.flags field by adding it into ECS along with the field's expected values (truncated, multiline)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants