Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update related.* field names from singular to plural #909

Closed
ebeahan opened this issue Aug 5, 2020 · 1 comment
Closed

Update related.* field names from singular to plural #909

ebeahan opened this issue Aug 5, 2020 · 1 comment
Labels
2.0.0 ready Issues we'd like to address in the future.

Comments

@ebeahan
Copy link
Member

ebeahan commented Aug 5, 2020

Description of the issue:

The related.* field set in ECS 1.x uses singular names. As suggested per an additional remark in #863 , using plural names would better align with the guidelines.

Any additional context or examples:

related.hash => related.hashes
related.ip => related.ips
related.user => related.users
related.host => related.hosts (not final)

@ebeahan ebeahan added bug Something isn't working 2.0.0 and removed bug Something isn't working labels Aug 5, 2020
@webmat webmat added the ready Issues we'd like to address in the future. label Aug 11, 2020
@webmat
Copy link
Contributor

webmat commented Nov 17, 2020

After further thought and discussion, we feel like this inconsistency on a few fields is not worth the pain of a breaking change.

We want to keep our breaking change "budget" for more pressing matters :-)

@webmat webmat closed this as completed Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.0 ready Issues we'd like to address in the future.
Projects
None yet
Development

No branches or pull requests

2 participants