Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent] Configuration validations on Fleet and Agent side #157

Open
ph opened this issue Feb 12, 2020 · 6 comments
Open

[Agent] Configuration validations on Fleet and Agent side #157

ph opened this issue Feb 12, 2020 · 6 comments
Labels
enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@ph
Copy link
Contributor

ph commented Feb 12, 2020

We allow people to see and edit the configuration in Fleet, it might be a good idea to share validations or at least high-level validations with the expected fields like ids, type and metricset. This can be also useful for communicating with other teams.

We have created an example configuration but this is not enough to express what we are expecting. We need a formal way to define it, one way would be to use a json-schema definition that could be used by both the agent and fleet.

@ph ph added the enhancement New feature or request label Feb 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest (Project:fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:ingest-management)

@jsoriano jsoriano added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@jlind23
Copy link
Contributor

jlind23 commented Nov 8, 2021

@nimarezainia Relevant from a customer experience?

@jlind23
Copy link
Contributor

jlind23 commented Mar 7, 2022

@ph Were you thinking of adding those validation inside fleet ui?

@jlind23 jlind23 transferred this issue from elastic/beats Mar 7, 2022
@ph
Copy link
Contributor Author

ph commented Mar 9, 2022

I believe it's a better user experience to catch user error as early as possible. This also has the adventages to reduce load on fleet-server and on the user network when a configuration is invalid.

I haven't investigated but, integration generates input and we can validate inputs at the process level maybe we can share the heuristic between our inputs and fleet to validate it?

The other way would be to take a random agent and ask to validate the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

5 participants