-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Agent] Configuration validations on Fleet and Agent side #157
Comments
Pinging @elastic/ingest (Project:fleet) |
Pinging @elastic/ingest-management (Team:ingest-management) |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
@nimarezainia Relevant from a customer experience? |
@ph Were you thinking of adding those validation inside fleet ui? |
I believe it's a better user experience to catch user error as early as possible. This also has the adventages to reduce load on fleet-server and on the user network when a configuration is invalid. I haven't investigated but, integration generates input and we can validate inputs at the process level maybe we can share the heuristic between our inputs and fleet to validate it? The other way would be to take a random agent and ask to validate the configuration. |
We allow people to see and edit the configuration in Fleet, it might be a good idea to share validations or at least high-level validations with the expected fields like ids, type and metricset. This can be also useful for communicating with other teams.
We have created an example configuration but this is not enough to express what we are expecting. We need a formal way to define it, one way would be to use a json-schema definition that could be used by both the agent and fleet.
The text was updated successfully, but these errors were encountered: