Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] No ES output validation can lead to stopped sub processes and no logs #320

Open
simitt opened this issue Feb 4, 2021 · 3 comments
Labels
enhancement New feature or request Team:Elastic-Agent Label for the Agent team

Comments

@simitt
Copy link
Contributor

simitt commented Feb 4, 2021

The Fleet settings UI allows for setting all kind of values in the Elasticsearch output configuration. There is no validation, allowing for any kind of input.

Observed behavior:

  • Setting enabled: false: the Elastic Agent kills the sub processes and only logs that it stoped the sub processes. No indicator why they are stopped, no additional entries in the sub process logs.
  • Using wrong type, e.g. bulk_max_size: "4s": Elastic Agent keeps restarting the sub processes, which can't start because they all have an invalid configuration. Subprocess logs include detailed information - helpful for debugging

Expected behavior:

  • the logs should always contain helpful information - if the Agent stops the sub processes, a reason should be logged.

Ideally there would be some validation preventing to store invalid configurations

  • only supported options could be allowed
  • loose validation - (most important) supported options are validated, other options are passed on but not validated

I wasn't certain whether this belongs here and/or to Fleet.

@simitt simitt added enhancement New feature or request Team:Elastic-Agent Label for the Agent team labels Feb 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/agent (Team:Agent)

@simitt
Copy link
Contributor Author

simitt commented Feb 17, 2021

Related: when having a managed policy, e.g. on Elastic Cloud, only a subset of the ES output settings should be allowed. For example the host or username and password should not be configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

No branches or pull requests

3 participants