Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] move service startup to beginning of run function #4971

Open
leehinman opened this issue Jun 20, 2024 · 1 comment
Open

[windows] move service startup to beginning of run function #4971

leehinman opened this issue Jun 20, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@leehinman
Copy link
Contributor

Currently elastic-agent does several things before it communicates with the Windows Service Manager and registers itself and reports as running.

go service.ProcessWindowsControlEvents(stopBeat)

This can cause problems because the service manager has a very short timeout between when it starts a process and expects that process to communicate that it is in StartPending state. For Windows we need to move this as close as possible to the start of the run function.

@leehinman leehinman added the bug Something isn't working label Jun 20, 2024
@cmacknz cmacknz added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 20, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

4 participants