Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet managed K8S resources should match standalone resources #2288

Merged

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Feb 16, 2023

The CPU and memory requests for a standalone agent were updated to higher values than what is currently used for Fleet managed agents. Update the managed configuration to match the standalone configuration there is no reason for them to be different.

@cmacknz cmacknz added Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team backport-v8.6.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify labels Feb 16, 2023
@cmacknz cmacknz self-assigned this Feb 16, 2023
@cmacknz cmacknz requested a review from a team as a code owner February 16, 2023 15:32
@cmacknz cmacknz requested review from gsantoro and devamanv and removed request for a team February 16, 2023 15:32
@cmacknz
Copy link
Member Author

cmacknz commented Feb 16, 2023

The current set of standalone resource requests for reference:

resources:
limits:
memory: 700Mi
requests:
cpu: 100m
memory: 400Mi

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-16T18:19:32.679+0000

  • Duration: 19 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 4919
Skipped 15
Total 4934

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 16, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.361% (60/61) 👍
Files 68.9% (144/209) 👍
Classes 68.08% (273/401) 👍
Methods 53.517% (837/1564) 👍
Lines 38.878% (9185/23625) 👍 0.047
Conditionals 100.0% (0/0) 💚

@cmacknz cmacknz requested a review from gizas February 16, 2023 16:16
@gsantoro
Copy link
Contributor

hey @cmacknz thanks for the PR, would you mind applying the same change at the following places

I'm sorry that there are so many places where those limits needs changing. We are working on it.

The CPU and memory requests for a standalone agent were updated to
higher values than what is currently used for Fleet managed agents.
Update the managed configuration to match the standalone configuration
there is no reason for them to be different.
@cmacknz cmacknz force-pushed the synchronize-fleet-standalone-mem-requests branch from 1c8cc0f to f4cb64e Compare February 16, 2023 17:19
@cmacknz
Copy link
Member Author

cmacknz commented Feb 16, 2023

/test

@cmacknz cmacknz merged commit 9c6c5ae into elastic:main Feb 16, 2023
@cmacknz cmacknz deleted the synchronize-fleet-standalone-mem-requests branch February 16, 2023 18:44
mergify bot pushed a commit that referenced this pull request Feb 16, 2023
The CPU and memory requests for a standalone agent were updated to
higher values than what is currently used for Fleet managed agents.
Update the managed configuration to match the standalone configuration
there is no reason for them to be different.

(cherry picked from commit 9c6c5ae)
mergify bot pushed a commit that referenced this pull request Feb 16, 2023
The CPU and memory requests for a standalone agent were updated to
higher values than what is currently used for Fleet managed agents.
Update the managed configuration to match the standalone configuration
there is no reason for them to be different.

(cherry picked from commit 9c6c5ae)

# Conflicts:
#	dev-tools/kubernetes/base/elastic-agent-managed/daemonset.yaml
@cmacknz cmacknz added backport-v8.6.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify and removed backport-v8.6.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify labels Feb 16, 2023
cmacknz added a commit that referenced this pull request Feb 16, 2023
The CPU and memory requests for a standalone agent were updated to
higher values than what is currently used for Fleet managed agents.
Update the managed configuration to match the standalone configuration
there is no reason for them to be different.

(cherry picked from commit 9c6c5ae)
cmacknz added a commit that referenced this pull request Feb 16, 2023
The CPU and memory requests for a standalone agent were updated to
higher values than what is currently used for Fleet managed agents.
Update the managed configuration to match the standalone configuration
there is no reason for them to be different.

(cherry picked from commit 9c6c5ae)
cmacknz added a commit that referenced this pull request Feb 16, 2023
The CPU and memory requests for a standalone agent were updated to
higher values than what is currently used for Fleet managed agents.
Update the managed configuration to match the standalone configuration
there is no reason for them to be different.

(cherry picked from commit 9c6c5ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.6.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants