Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs/filebeat.spec.yml - Re-add lumberjack input #2511

Merged
merged 2 commits into from Apr 19, 2023

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Apr 18, 2023

What does this PR do?

Between v8.5.3 and v8.6.0 the lumberjack input was lost from the filebeat spec file.

From v8.5.3:

Why is it important?

The barracuda_cloudgen_firewall integration depends on this input type.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

Logs

From v8.6.0 when running https://docs.elastic.co/integrations/barracuda_cloudgen_firewall.

{
  "@timestamp": "2023-04-18T17:03:46.412Z",
  "component": {
    "id": "lumberjack-default",
    "state": "FAILED"
  },
  "ecs.version": "1.6.0",
  "log.level": "error",
  "log.origin": {
    "file.line": 833,
    "file.name": "coordinator/coordinator.go"
  },
  "message": "Spawned new unit lumberjack-default: input not supported",
  "unit": {
    "id": "lumberjack-default",
    "state": "FAILED",
    "type": "output"
  }
}

Between v8.5.3 and v8.6.0 the lumberjack input was lost from the
filebeat spec file.
@andrewkroh andrewkroh added bug Something isn't working backport-v8.7.0 Automated backport with mergify labels Apr 18, 2023
@andrewkroh andrewkroh requested a review from a team as a code owner April 18, 2023 17:09
@andrewkroh andrewkroh requested review from michalpristas and michel-laterman and removed request for a team April 18, 2023 17:09
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-18T19:17:53.754+0000

  • Duration: 17 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 5535
Skipped 19
Total 5554

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 18, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.529% (67/68) 👍
Files 68.22% (161/236) 👍
Classes 67.785% (303/447) 👍
Methods 54.111% (928/1715) 👍
Lines 39.612% (10503/26515) 👎 -0.008
Conditionals 100.0% (0/0) 💚

@andrewkroh
Copy link
Member Author

/test

@andrewkroh
Copy link
Member Author

Is anything else needed on this? If not, could someone from the Agent team merge this please.

@blakerouse blakerouse merged commit 8da86c6 into elastic:main Apr 19, 2023
17 checks passed
mergify bot pushed a commit that referenced this pull request Apr 19, 2023
* specs/filebeat.spec.yml - Re-add lumberjack input

Between v8.5.3 and v8.6.0 the lumberjack input was lost from the
filebeat spec file.

* Add changelog fragment

(cherry picked from commit 8da86c6)
cmacknz pushed a commit that referenced this pull request Apr 20, 2023
* specs/filebeat.spec.yml - Re-add lumberjack input

Between v8.5.3 and v8.6.0 the lumberjack input was lost from the
filebeat spec file.

* Add changelog fragment

(cherry picked from commit 8da86c6)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.7.0 Automated backport with mergify bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants