Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.7.1 release notes #2513

Merged
merged 9 commits into from
Apr 25, 2023
Merged

Conversation

ycombinator
Copy link
Contributor

This PR generates the 8.7.1 release notes.

The release notes were generated by running elastic-agent-changelog-tool build --version 8.7.1. Then, all changelog/fragments/* files were deleted.

@ycombinator ycombinator requested review from a team as code owners April 18, 2023 18:24
@ycombinator ycombinator requested review from gsantoro, tetianakravchenko, AndersonQ, pchila, pierrehilbert and cmacknz and removed request for a team April 18, 2023 18:24
@ycombinator ycombinator changed the base branch from main to 8.7 April 18, 2023 18:25
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-24T19:41:22.043+0000

  • Duration: 18 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 5115
Skipped 23
Total 5138

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 18, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.462% (64/65) 👍
Files 68.837% (148/215) 👍
Classes 67.971% (278/409) 👍
Methods 53.737% (870/1619) 👍
Lines 39.171% (9758/24911) 👍 0.044
Conditionals 100.0% (0/0) 💚

@pierrehilbert
Copy link
Contributor

The content here is different from https://github.com/elastic/ingest-docs/pull/150/files
Should we adapt summary to match?

@ycombinator
Copy link
Contributor Author

The content here is different from https://github.com/elastic/ingest-docs/pull/150/files Should we adapt summary to match?

Yes, good catch @pierrehilbert. I will update this PR here to match the contents of https://github.com/elastic/ingest-docs/pull/150/files (for Agent related items only, of course).

Going forward, how do we prevent such a mismatch? Is there any fixed ordering we should follow - e.g. the PR to the https://github.com/elastic/elastic-agent repo first, after which the PR to https://github.com/elastic/ingest-docs/ is created with matching content or vice versa?

@pierrehilbert
Copy link
Contributor

I think the best way is to generate the changelog on this repo first and then, docs team could update this one if they are changing something.

changelog/8.7.1.yaml Outdated Show resolved Hide resolved
- kind: bug-fix
summary: Fix actions acks delay
description: |
Fixes a bug that caused delayed "ack" response following Osquerybeat query
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fixes a bug that caused delayed "ack" response following Osquerybeat query
Fix for OSQuery live query results taking up to five minutes to show up in Kibana.

This matches the language in the known issue for this bug https://www.elastic.co/guide/en/fleet/current/release-notes-8.7.0.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make the description text here the same as your suggestion in elastic/ingest-docs#150 (comment)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make the description text here the same as your suggestion in elastic/ingest-docs#150 (comment)?

Done in 8f76938.

changelog/8.7.1.yaml Outdated Show resolved Hide resolved
changelog/8.7.1.yaml Outdated Show resolved Hide resolved
@ycombinator
Copy link
Contributor Author

ycombinator commented Apr 20, 2023

@cmacknz I applied your suggestions from the feedback, updated some descriptions to match your suggestions from elastic/ingest-docs#150, and added a new entry that'll be included in the next BC.

Please re-review when you get a chance, thanks!

ycombinator and others added 4 commits April 24, 2023 12:34
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
@ycombinator
Copy link
Contributor Author

Added one more entry to the changelog for a change that made it into BC3.

Copy link
Contributor

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator ycombinator merged commit 10dc6a0 into elastic:8.7 Apr 25, 2023
17 checks passed
@ycombinator ycombinator deleted the 8.7.1-release-notes branch April 25, 2023 13:35
mergify bot pushed a commit that referenced this pull request Apr 25, 2023
* Generate 8.7.1 release notes

* Fixing links

* Making descriptions consistent with docs

* Match language with release notes documentation

* Update changelog/8.7.1.yaml

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Update changelog/8.7.1.yaml

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Update changelog/8.7.1.yaml

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Adding new entry

* Adding new entry

---------

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
(cherry picked from commit 10dc6a0)

# Conflicts:
#	changelog/fragments/1681211832-empty-proxy-from-the-policy-don't-overrides-the-proxy-set-by---proxy-url.yaml
@@ -0,0 +1,111 @@
version: 8.7.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belated comment, looks like we missed 2d90292 here and in the official release notes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, we did. Thanks for catching. It looks like the PR for that change didn't add a CHANGELOG fragment file, which is why it didn't get included here.

I'll make a follow up PR to directly add an entry to the 8.7.1.yaml file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a follow up PR to directly add an entry to the 8.7.1.yaml file.

#2577

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @kilfoyle, for reviewing #2577 and for incorporating the missed entry into the official release notes as well.

ycombinator added a commit that referenced this pull request May 3, 2023
* Generate 8.7.1 release notes

* Fixing links

* Making descriptions consistent with docs

* Match language with release notes documentation

* Update changelog/8.7.1.yaml

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Update changelog/8.7.1.yaml

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Update changelog/8.7.1.yaml

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Adding new entry

* Adding new entry

---------

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
(cherry picked from commit 10dc6a0)

# Conflicts:
#	changelog/fragments/1681211832-empty-proxy-from-the-policy-don't-overrides-the-proxy-set-by---proxy-url.yaml
ycombinator added a commit that referenced this pull request May 3, 2023
* 8.7.1 release notes (#2513)

* Generate 8.7.1 release notes

* Fixing links

* Making descriptions consistent with docs

* Match language with release notes documentation

* Update changelog/8.7.1.yaml

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Update changelog/8.7.1.yaml

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Update changelog/8.7.1.yaml

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Adding new entry

* Adding new entry

---------

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
(cherry picked from commit 10dc6a0)

# Conflicts:
#	changelog/fragments/1681211832-empty-proxy-from-the-policy-don't-overrides-the-proxy-set-by---proxy-url.yaml

* Remove fragment files used in 8.7.1 CHANGELOG

---------

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants