Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update synthetics deps #2696

Merged
merged 4 commits into from May 25, 2023
Merged

Update synthetics deps #2696

merged 4 commits into from May 25, 2023

Conversation

andrewvc
Copy link
Contributor

Bumps the node version to the 18.x to match heartbeat (see elastic/beats#35470) and also updates Dockerfile.tmpl which may not be used, I'd like to delete it if possible.

@andrewvc andrewvc added bug Something isn't working Team:Uptime Label for the Uptime team v8.8.0 backport-v8.8.0 Automated backport with mergify labels May 15, 2023
@andrewvc andrewvc requested a review from a team as a code owner May 15, 2023 18:26
@andrewvc andrewvc self-assigned this May 15, 2023
@mergify
Copy link
Contributor

mergify bot commented May 15, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update-synthetics-deps upstream/update-synthetics-deps
git merge upstream/main
git push upstream update-synthetics-deps

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 15, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-18T19:19:03.212+0000

  • Duration: 41 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 5659
Skipped 19
Total 5678

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 15, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.611% (71/72) 👍
Files 68.273% (170/249) 👍
Classes 67.021% (315/470) 👍
Methods 53.652% (955/1780) 👍
Lines 39.421% (10965/27815) 👍 0.029
Conditionals 100.0% (0/0) 💚

@cla-checker-service
Copy link

cla-checker-service bot commented May 16, 2023 •
edited

💚 CLA has been signed

@andrewvc andrewvc requested a review from emilioalvap May 16, 2023 18:56
emilioalvap
emilioalvap approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc
Changelog
3612a35 
Remove unused dockerfile
@andrewvc andrewvc merged commit ad6dbe7 into elastic:main May 25, 2023
24 checks passed
@andrewvc andrewvc deleted the update-synthetics-deps branch May 25, 2023 22:43
mergify bot pushed a commit that referenced this pull request May 25, 2023
@andrewvc @mergify
Update synthetics deps (#2696)
c537942 
* Update synthetics docker deps

* Update dockerfile.tmpl, perhaps unnecessarily

* Changelog

Remove unused dockerfile

(cherry picked from commit ad6dbe7)
@mergify mergify bot mentioned this pull request May 25, 2023
Closed
ChrsMark pushed a commit to ChrsMark/elastic-agent that referenced this pull request May 29, 2023
@andrewvc @ChrsMark
Update synthetics deps (elastic#2696)
cf75833 
* Update synthetics docker deps

* Update dockerfile.tmpl, perhaps unnecessarily

* Changelog

Remove unused dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@emilioalvap emilioalvap emilioalvap approved these changes

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@andrewvc andrewvc

Labels
backport-v8.8.0 Automated backport with mergify bug Something isn't working Team:Uptime Label for the Uptime team v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewvc @elasticmachine @cmacknz @emilioalvap