Deprecating old technology #1845
Conversation
There was a problem hiding this comment.
Thanks @masseyke. I left some non-blocking suggestions, but this looks good to me overall. I'll defer to @debadair for final docs approval.
Outside the scope of this PR, but @debadair or I can take a look at updating the "Breaking changes" page to be more inline with the Elasticsearch migration guide. We can look at removing some of the info for older major versions as part of that effort.
spark/sql-13/src/main/scala/org/elasticsearch/spark/sql/package.scala
Outdated
Show resolved
Hide resolved
spark/sql-13/src/main/scala/org/elasticsearch/spark/sql/package.scala
Outdated
Show resolved
Hide resolved
spark/sql-13/src/main/scala/org/elasticsearch/spark/streaming/EsSparkStreaming.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
| @@ -47,6 +47,7 @@ | |||
| import static org.elasticsearch.storm.cfg.StormConfigurationOptions.ES_STORM_BOLT_ACK; | |||
|
|
|||
| @SuppressWarnings({ "rawtypes", "unchecked" }) | |||
| @Deprecated | |||
There was a problem hiding this comment.
Should we add a javadoc message here for the deprecation?
/**
* @deprecated Storm support is deprecated and will be removed in a future release
*/There was a problem hiding this comment.
Yeah I had considered that, and then decided not to, and can't remember why. Just added it now though.
| @@ -49,6 +49,7 @@ | |||
| import static org.elasticsearch.hadoop.cfg.ConfigurationOptions.*; | |||
|
|
|||
| @SuppressWarnings({ "rawtypes", "unchecked" }) | |||
| @Deprecated | |||
There was a problem hiding this comment.
Same suggestion here for javadoc message
This commit deprecates spark 1.x, scala 2.10 on spark 2.x, hadoop 1, pig, and storm. Support will be removed for these things at a later date.
This commit deprecates spark 1.x, scala 2.10 on spark 2.x, hadoop 1, pig, and storm. Support will be removed for these things at a later date.