-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting rid of direct cross-project dependencies to avoid gradle warnings #1868
Conversation
Here's an example of the warning I had been getting before this change:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I think it can be simplified a little by declaring the configuration and artifact in org.elasticsearch.hadoop.gradle.BuildPlugin#createItestTask
Configuration itestJarConfig = project.getConfigurations().maybeCreate("itestJarConfig")
itestJarConfig.canBeConsumed = Boolean.TRUE
itestJarConfig.canBeResolved = Boolean.FALSE
project.getArtifacts().add(itestJarConfig.getName(), itestJar)
just after the declaration or configuration of itestJar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ings (elastic#1868) This commit avoids gradle warnings when running ./gradlew :qa:kerberos:compileJava. The :qa:kerberos project had been directly pulling in the itest.runtimeClasspath from the storm and hadoop-mr projects, which is not allowed in gradle 8.
Closes #1812 |
This commit avoids gradle warnings when running ./gradlew :qa:kerberos:compileJava. The :qa:kerberos project
had been directly pulling in the itest.runtimeClasspath from the storm and hadoop-mr projects, which is not allowed
in gradle 8.