New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#958 - added transient to loggers where necessary #959

Merged
merged 1 commit into from Apr 25, 2017

Conversation

Projects
None yet
3 participants
@xjrk58
Contributor

xjrk58 commented Apr 11, 2017

Fixes #958

Adds transient annotation to all loggers to avoid serialization issues

  • [X ] I have signed the [Contributor License Agreement (CLA)][]

@xjrk58 xjrk58 closed this Apr 11, 2017

@xjrk58 xjrk58 reopened this Apr 11, 2017

@karmi

This comment has been minimized.

Show comment
Hide comment
@karmi

karmi Apr 11, 2017

Member

Hi @xjrk58, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Member

karmi commented Apr 11, 2017

Hi @xjrk58, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

1 similar comment
@karmi

This comment has been minimized.

Show comment
Hide comment
@karmi

karmi Apr 11, 2017

Member

Hi @xjrk58, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Member

karmi commented Apr 11, 2017

Hi @xjrk58, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@xjrk58

This comment has been minimized.

Show comment
Hide comment
@xjrk58

xjrk58 Apr 11, 2017

Contributor

@karmi I've added it as well.

Contributor

xjrk58 commented Apr 11, 2017

@karmi I've added it as well.

@xjrk58 xjrk58 closed this Apr 11, 2017

@xjrk58 xjrk58 reopened this Apr 11, 2017

@jbaiera jbaiera self-requested a review Apr 25, 2017

@jbaiera

This LGTM

@jbaiera jbaiera merged commit 54d9cf4 into elastic:master Apr 25, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jbaiera added a commit that referenced this pull request Apr 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment