Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#958 - added transient to loggers where necessary #959

Merged
merged 1 commit into from
Apr 25, 2017
Merged

#958 - added transient to loggers where necessary #959

merged 1 commit into from
Apr 25, 2017

Conversation

xjrk58
Copy link
Contributor

@xjrk58 xjrk58 commented Apr 11, 2017 •
edited
Loading

Fixes #958

Adds transient annotation to all loggers to avoid serialization issues

  • [X ] I have signed the [Contributor License Agreement (CLA)][]

@xjrk58 xjrk58 closed this Apr 11, 2017
@xjrk58 xjrk58 reopened this Apr 11, 2017
@karmi
Copy link

karmi commented Apr 11, 2017

Hi @xjrk58, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

1 similar comment
@karmi
Copy link

karmi commented Apr 11, 2017

Hi @xjrk58, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@xjrk58
Copy link
Contributor Author

xjrk58 commented Apr 11, 2017

@karmi I've added it as well.

@xjrk58 xjrk58 closed this Apr 11, 2017
@xjrk58 xjrk58 reopened this Apr 11, 2017
@jbaiera jbaiera self-requested a review April 25, 2017 19:23
jbaiera
jbaiera approved these changes Apr 25, 2017
View reviewed changes
Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@jbaiera jbaiera merged commit 54d9cf4 into elastic:master Apr 25, 2017
jbaiera pushed a commit that referenced this pull request Apr 27, 2017
@xjrk58 @jbaiera
Added transient to loggers where necessary (#959)
51e0b5e 
fixes #958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaiera jbaiera jbaiera approved these changes

Assignees
No one assigned
Labels
bug :Spark v5.3.2 v6.0.0-alpha1 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xjrk58 @karmi @jbaiera