Move to Nullean.Xunit.Partitions #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
commented
Feb 9, 2024
| @@ -8,7 +8,6 @@ | |||
|
|
|||
| namespace Elastic.Xunit.ExampleComplex | |||
| { | |||
| [IntegrationTestCluster(typeof(TestCluster))] | |||
There was a problem hiding this comment.
Reviewing note: this removes support for marking clusters through attributes. In the spirit of simplifying marking test classes with IClusterFixture<> is now the sole way to get clusters injected.
This was introduced in: elastic/elasticsearch-net#3424
Since this was not ported to the new tests for the new client I think its safe to remove.
|
@flobernd tagging you since pulling this in would affect you the most: https://github.com/elastic/elasticsearch-net/blob/main/tests/Tests.Core/Tests.Core.csproj#L19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've extracted the custom test runner bits to the more generic: https://www.nuget.org/packages/Nullean.Xunit.Partitions/
This PR takes a dependency on it so that
Elastic.Xunit.Elasticsearchcan simplify it's src/Elastic.Elasticsearch.Xunit/Sdk/TestAssemblyRunner.cs implementation and ceremony.Breaking changes should be limited.