Refactor/analysis tests #3424
Merged
Refactor/analysis tests #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses to do full blown endpoint testing (cherry picked from commit d6f1ae5)
(cherry picked from commit f5f0c437871589b1fb90b6c4c6f09f0dfc296d7e)
(cherry picked from commit c74ed51e2c30804ffc1d50f95a17893a93bfa6ea)
(cherry picked from commit f2da9f51b43b188cc1b2d09f616fbf87ca268344)
(cherry picked from commit 7ecbee5435df02810ede7f07985e7bb13f66b6f3)
…ch implements the bulk of the setup and tests (cherry picked from commit 8a6e99493a4174a87cc8680609afd0c482cf10d7)
This was referenced Sep 28, 2018
Merged
russcam
approved these changes
Oct 13, 2018
|
|
||
| protected AnalysisComponentTestBase() | ||
| { | ||
| this.Client = (ElasticXunitRunner.CurrentCluster as ReadOnlyCluster)?.Client ?? TestClient.DefaultInMemoryClient; |
There was a problem hiding this comment.
Would ElasticXunitRunner.CurrentCluster be a WritableCluster at this point, to match the one requested by IntegrationTestClusterAttribute?
russcam
pushed a commit
that referenced
this pull request
Oct 26, 2018
This commit refactors the way we do analysis tests by making it easier for test classes to do full blown endpoint testing (cherry picked from commit d6f1ae5) * continuing to port analysis over to more isolated chunks (cherry picked from commit f5f0c437871589b1fb90b6c4c6f09f0dfc296d7e) * Ported normalizers over to new test format (cherry picked from commit c74ed51e2c30804ffc1d50f95a17893a93bfa6ea) * clean up namespaces (cherry picked from commit f2da9f51b43b188cc1b2d09f616fbf87ca268344) * All analysis unit/integ tests pass again (cherry picked from commit 7ecbee5435df02810ede7f07985e7bb13f66b6f3) * abstracted analysis base classes even further to all share a base which implements the bulk of the setup and tests (cherry picked from commit 8a6e99493a4174a87cc8680609afd0c482cf10d7) (cherry picked from commit 6461c8f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we take a all or nothing approach with our analysis tests, we unit test
analyzers/filter/char_filter/normalizers/tokenizersand then lift these in aAnalysisCrudTestto test that elasticsearch accepts them. Problem is when new analysis components get introduced in a minor we need to add to the list and do a[SkipVersion()]on everything. Which causes us to test these in practice only against the latest version.This PR pulls all of these apart so that if a new analysis component gets introduced we can make it with
SkipVersionin isolation.To minimize the boilerplate this PR also updates
Elastic.Xunitwhich now allows testclasses to declare a cluster to run against using anAttribute. Prior an integration test needed to implementIClusterFixture<TCluster>and acceptTClusterin its constructor. Which causes all subclasses needing to implement this constructor which gets super noisy.Tests can then refer to the
"active"cluster usingElasticXunitRunner.CurrentCluster.There are other places where this approach will work well as well, Ingest Processors comes to mind.
This PR also pulls
EndpointUsage,CallUniqueValuesout ofApiIntegrationTestsBaseallowing other test classes easier access to testing an client API call with the same call once guarantees.This PR does not move
ApiIntegrationTestsBaseitself over.