Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate sort on ReindexOnServer #4357

Merged
merged 2 commits into from
Feb 9, 2020
Merged

Deprecate sort on ReindexOnServer #4357

merged 2 commits into from
Feb 9, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Feb 4, 2020

Relates: #4341

Deprecate sorting in reindex elastic/elasticsearch#49458 (issue: elastic/elasticsearch#47567)

Closes #4356

@russcam russcam mentioned this pull request Feb 4, 2020
Closed
@Mpdreamz
Copy link
Member

Mpdreamz commented Feb 4, 2020

Document/Multiple/ReindexOnServer/ReindexOnServerSliceApiTests.cs(49,17): error CS0618: 'ReindexSourceDescriptor.Sort(Func<SortDescriptor, IPromise<IList>>)' is obsolete: 'Deprecated in 7.6.0. Instead consider using query filtering to find the desired subset of data.' [/home/vsts/work/1/s/tests/Tests/Tests.csproj]
Document/Multiple/ReindexOnServer/ReindexOnServerSliceApiTests.cs(81,5): error CS0618: 'ReindexSource.Sort' is obsolete: 'Deprecated in 7.6.0. Instead consider using query filtering to find the desired subset of data.' [/home/vsts/work/1/s/tests/Tests/Tests.csproj]
0 Warning(s)
2 Error(s)

Mpdreamz
Mpdreamz requested changes Feb 4, 2020
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes itself LGTM but the tests need updating as well since they now use a deprecated method and cause the build to fail

@Mpdreamz
Copy link
Member

Mpdreamz commented Feb 4, 2020

Port to master?

@russcam
Copy link
Contributor Author

russcam commented Feb 5, 2020

Port to master?

Yes, although probably should be removed in master?

@russcam
Copy link
Contributor Author

russcam commented Feb 5, 2020

thanks for catching the test usage, fixed!

@Mpdreamz Mpdreamz self-requested a review February 7, 2020 10:42
@russcam russcam merged commit 20a2133 into 7.x Feb 9, 2020
russcam added a commit that referenced this pull request Feb 9, 2020
@russcam
Deprecate sort on ReindexOnServer (#4357)
aab4d3c 
Relates: #4341

Deprecate sorting in reindex elastic/elasticsearch#49458 (issue: elastic/elasticsearch#47567)

Closes #4356

(cherry picked from commit 20a2133)
@russcam
Copy link
Contributor Author

russcam commented Feb 9, 2020

ported to master aab4d3c. Will leave the removing part when we come to look at 8.x

@Mpdreamz Mpdreamz deleted the deprecations/7x/reindex-on-server-sort branch February 10, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
backport main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russcam @Mpdreamz