-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_all_chunks_sent is flaky #701
Comments
I have run this test several times but this particular test does not fail. I ran this using python setup.py test. Any other info that may be pertinent? |
Hrm, the test seems to be very slightly flaky. I didn't yet find a way to reproduce it stably. |
@felixonmars thanks for the issue, but just like @silne30 I can't find a way to reproduce the flaky-ness of this test. I'm going to close this now. But if you can find a way to reproduce the failure please re-open the ticket. Thank you |
elasticsearch5 (this port) unnecessarily pins its urllib dependency to < 1.23, which blocks updating urllib3 to 1.24 [1]: ./textproc/py-elasticsearch5: setup.py: 'urllib3<1.23,>=1.21.1', The package had a history of issues/conflicts/bugs with the urllib3 dependency, ultimately resulting in the maximum version pin being removed [2]: elastic/elasticsearch-py#807 elastic/elasticsearch-py#667 elastic/elasticsearch-py#634 This commit backports that change, a functional noop and sweeping change in advance required for a urllib3 update, and adds TEST_DEPENDS and a test target to support rigorous and confident QA. Switching to GitHub sources was required as the PyPI sdist does not package tests. The packages tests all pass with/against urllib3 1.24 installed, with an intermittent and non-deterministic off-by-one failure in one test: FAIL: test_all_chunks_sent (test_elasticsearch.test_helpers.TestParallelBulk) The issue exists independent of urllib3 version. The flaky test issue was reported upstream [3], but was not resolved. [2] elastic/elasticsearch-py@4352e56 [3] elastic/elasticsearch-py#701 PR: 229322 [1] Approved by: portmgr (blanket: framework compliance, runtime bugfix) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@499073 35697150-7ecd-e111-bb59-0022644237b5
elasticsearch5 (this port) unnecessarily pins its urllib dependency to < 1.23, which blocks updating urllib3 to 1.24 [1]: ./textproc/py-elasticsearch5: setup.py: 'urllib3<1.23,>=1.21.1', The package had a history of issues/conflicts/bugs with the urllib3 dependency, ultimately resulting in the maximum version pin being removed [2]: elastic/elasticsearch-py#807 elastic/elasticsearch-py#667 elastic/elasticsearch-py#634 This commit backports that change, a functional noop and sweeping change in advance required for a urllib3 update, and adds TEST_DEPENDS and a test target to support rigorous and confident QA. Switching to GitHub sources was required as the PyPI sdist does not package tests. The packages tests all pass with/against urllib3 1.24 installed, with an intermittent and non-deterministic off-by-one failure in one test: FAIL: test_all_chunks_sent (test_elasticsearch.test_helpers.TestParallelBulk) The issue exists independent of urllib3 version. The flaky test issue was reported upstream [3], but was not resolved. [2] elastic/elasticsearch-py@4352e56 [3] elastic/elasticsearch-py#701 PR: 229322 [1] Approved by: portmgr (blanket: framework compliance, runtime bugfix)
elasticsearch5 (this port) unnecessarily pins its urllib dependency to < 1.23, which blocks updating urllib3 to 1.24 [1]: ./textproc/py-elasticsearch5: setup.py: 'urllib3<1.23,>=1.21.1', The package had a history of issues/conflicts/bugs with the urllib3 dependency, ultimately resulting in the maximum version pin being removed [2]: elastic/elasticsearch-py#807 elastic/elasticsearch-py#667 elastic/elasticsearch-py#634 This commit backports that change, a functional noop and sweeping change in advance required for a urllib3 update, and adds TEST_DEPENDS and a test target to support rigorous and confident QA. Switching to GitHub sources was required as the PyPI sdist does not package tests. The packages tests all pass with/against urllib3 1.24 installed, with an intermittent and non-deterministic off-by-one failure in one test: FAIL: test_all_chunks_sent (test_elasticsearch.test_helpers.TestParallelBulk) The issue exists independent of urllib3 version. The flaky test issue was reported upstream [3], but was not resolved. [2] elastic/elasticsearch-py@4352e56 [3] elastic/elasticsearch-py#701 PR: 229322 [1] Approved by: portmgr (blanket: framework compliance, runtime bugfix) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@499073 35697150-7ecd-e111-bb59-0022644237b5
elasticsearch5 (this port) unnecessarily pins its urllib dependency to < 1.23, which blocks updating urllib3 to 1.24 [1]: ./textproc/py-elasticsearch5: setup.py: 'urllib3<1.23,>=1.21.1', The package had a history of issues/conflicts/bugs with the urllib3 dependency, ultimately resulting in the maximum version pin being removed [2]: elastic/elasticsearch-py#807 elastic/elasticsearch-py#667 elastic/elasticsearch-py#634 This commit backports that change, a functional noop and sweeping change in advance required for a urllib3 update, and adds TEST_DEPENDS and a test target to support rigorous and confident QA. Switching to GitHub sources was required as the PyPI sdist does not package tests. The packages tests all pass with/against urllib3 1.24 installed, with an intermittent and non-deterministic off-by-one failure in one test: FAIL: test_all_chunks_sent (test_elasticsearch.test_helpers.TestParallelBulk) The issue exists independent of urllib3 version. The flaky test issue was reported upstream [3], but was not resolved. [2] elastic/elasticsearch-py@4352e56 [3] elastic/elasticsearch-py#701 PR: 229322 [1] Approved by: portmgr (blanket: framework compliance, runtime bugfix) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@499073 35697150-7ecd-e111-bb59-0022644237b5
elasticsearch5 (this port) unnecessarily pins its urllib dependency to < 1.23, which blocks updating urllib3 to 1.24 [1]: ./textproc/py-elasticsearch5: setup.py: 'urllib3<1.23,>=1.21.1', The package had a history of issues/conflicts/bugs with the urllib3 dependency, ultimately resulting in the maximum version pin being removed [2]: elastic/elasticsearch-py#807 elastic/elasticsearch-py#667 elastic/elasticsearch-py#634 This commit backports that change, a functional noop and sweeping change in advance required for a urllib3 update, and adds TEST_DEPENDS and a test target to support rigorous and confident QA. Switching to GitHub sources was required as the PyPI sdist does not package tests. The packages tests all pass with/against urllib3 1.24 installed, with an intermittent and non-deterministic off-by-one failure in one test: FAIL: test_all_chunks_sent (test_elasticsearch.test_helpers.TestParallelBulk) The issue exists independent of urllib3 version. The flaky test issue was reported upstream [3], but was not resolved. [2] elastic/elasticsearch-py@4352e56 [3] elastic/elasticsearch-py#701 PR: 229322 [1] Approved by: portmgr (blanket: framework compliance, runtime bugfix)
elasticsearch5 (this port) unnecessarily pins its urllib dependency to < 1.23, which blocks updating urllib3 to 1.24 [1]: ./textproc/py-elasticsearch5: setup.py: 'urllib3<1.23,>=1.21.1', The package had a history of issues/conflicts/bugs with the urllib3 dependency, ultimately resulting in the maximum version pin being removed [2]: elastic/elasticsearch-py#807 elastic/elasticsearch-py#667 elastic/elasticsearch-py#634 This commit backports that change, a functional noop and sweeping change in advance required for a urllib3 update, and adds TEST_DEPENDS and a test target to support rigorous and confident QA. Switching to GitHub sources was required as the PyPI sdist does not package tests. The packages tests all pass with/against urllib3 1.24 installed, with an intermittent and non-deterministic off-by-one failure in one test: FAIL: test_all_chunks_sent (test_elasticsearch.test_helpers.TestParallelBulk) The issue exists independent of urllib3 version. The flaky test issue was reported upstream [3], but was not resolved. [2] elastic/elasticsearch-py@4352e56 [3] elastic/elasticsearch-py#701 PR: 229322 [1] Approved by: portmgr (blanket: framework compliance, runtime bugfix)
Tested with Python 2.7.14, elasticsearch-py 6.1.0. A simple retry passes the tests, so I assume it's slightly flaky:
The text was updated successfully, but these errors were encountered: