Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Apparent inconsistency in requests and elasticsearch urllib3 dependency #634
In the latest setup.py commit (f1267b5) the dependency on urllib3 was changed to 'urllib3<1.22,>=1.21.1'. The commit was titled "Fix urllib3 version to be compatible with requests". However, earlier that same day there had been a commit on requests (which is now in the latest release) to update the urllib3 dependency from 'urllib3>=1.21.1,<1.22' to 'urllib3>=1.21.1,<1.23' (kennethreitz/requests@8d1228c).
So the question is, since requests 2.18.2-2.18.4 is ok with urllib3 1.22, is elasticsearch ok with urllib3 1.22?