Apparent inconsistency in requests and elasticsearch urllib3 dependency #634
Comments
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this issue
Apr 16, 2019
elasticsearch5 (this port) unnecessarily pins its urllib dependency to < 1.23, which blocks updating urllib3 to 1.24 [1]: ./textproc/py-elasticsearch5: setup.py: 'urllib3<1.23,>=1.21.1', The package had a history of issues/conflicts/bugs with the urllib3 dependency, ultimately resulting in the maximum version pin being removed [2]: elastic/elasticsearch-py#807 elastic/elasticsearch-py#667 elastic/elasticsearch-py#634 This commit backports that change, a functional noop and sweeping change in advance required for a urllib3 update, and adds TEST_DEPENDS and a test target to support rigorous and confident QA. Switching to GitHub sources was required as the PyPI sdist does not package tests. The packages tests all pass with/against urllib3 1.24 installed, with an intermittent and non-deterministic off-by-one failure in one test: FAIL: test_all_chunks_sent (test_elasticsearch.test_helpers.TestParallelBulk) The issue exists independent of urllib3 version. The flaky test issue was reported upstream [3], but was not resolved. [2] elastic/elasticsearch-py@4352e56 [3] elastic/elasticsearch-py#701 PR: 229322 [1] Approved by: portmgr (blanket: framework compliance, runtime bugfix) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@499073 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this issue
Apr 16, 2019
elasticsearch5 (this port) unnecessarily pins its urllib dependency to < 1.23, which blocks updating urllib3 to 1.24 [1]: ./textproc/py-elasticsearch5: setup.py: 'urllib3<1.23,>=1.21.1', The package had a history of issues/conflicts/bugs with the urllib3 dependency, ultimately resulting in the maximum version pin being removed [2]: elastic/elasticsearch-py#807 elastic/elasticsearch-py#667 elastic/elasticsearch-py#634 This commit backports that change, a functional noop and sweeping change in advance required for a urllib3 update, and adds TEST_DEPENDS and a test target to support rigorous and confident QA. Switching to GitHub sources was required as the PyPI sdist does not package tests. The packages tests all pass with/against urllib3 1.24 installed, with an intermittent and non-deterministic off-by-one failure in one test: FAIL: test_all_chunks_sent (test_elasticsearch.test_helpers.TestParallelBulk) The issue exists independent of urllib3 version. The flaky test issue was reported upstream [3], but was not resolved. [2] elastic/elasticsearch-py@4352e56 [3] elastic/elasticsearch-py#701 PR: 229322 [1] Approved by: portmgr (blanket: framework compliance, runtime bugfix)
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this issue
Apr 16, 2019
elasticsearch5 (this port) unnecessarily pins its urllib dependency to < 1.23, which blocks updating urllib3 to 1.24 [1]: ./textproc/py-elasticsearch5: setup.py: 'urllib3<1.23,>=1.21.1', The package had a history of issues/conflicts/bugs with the urllib3 dependency, ultimately resulting in the maximum version pin being removed [2]: elastic/elasticsearch-py#807 elastic/elasticsearch-py#667 elastic/elasticsearch-py#634 This commit backports that change, a functional noop and sweeping change in advance required for a urllib3 update, and adds TEST_DEPENDS and a test target to support rigorous and confident QA. Switching to GitHub sources was required as the PyPI sdist does not package tests. The packages tests all pass with/against urllib3 1.24 installed, with an intermittent and non-deterministic off-by-one failure in one test: FAIL: test_all_chunks_sent (test_elasticsearch.test_helpers.TestParallelBulk) The issue exists independent of urllib3 version. The flaky test issue was reported upstream [3], but was not resolved. [2] elastic/elasticsearch-py@4352e56 [3] elastic/elasticsearch-py#701 PR: 229322 [1] Approved by: portmgr (blanket: framework compliance, runtime bugfix) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@499073 35697150-7ecd-e111-bb59-0022644237b5
swills
pushed a commit
to swills/freebsd-ports
that referenced
this issue
Apr 19, 2019
elasticsearch5 (this port) unnecessarily pins its urllib dependency to < 1.23, which blocks updating urllib3 to 1.24 [1]: ./textproc/py-elasticsearch5: setup.py: 'urllib3<1.23,>=1.21.1', The package had a history of issues/conflicts/bugs with the urllib3 dependency, ultimately resulting in the maximum version pin being removed [2]: elastic/elasticsearch-py#807 elastic/elasticsearch-py#667 elastic/elasticsearch-py#634 This commit backports that change, a functional noop and sweeping change in advance required for a urllib3 update, and adds TEST_DEPENDS and a test target to support rigorous and confident QA. Switching to GitHub sources was required as the PyPI sdist does not package tests. The packages tests all pass with/against urllib3 1.24 installed, with an intermittent and non-deterministic off-by-one failure in one test: FAIL: test_all_chunks_sent (test_elasticsearch.test_helpers.TestParallelBulk) The issue exists independent of urllib3 version. The flaky test issue was reported upstream [3], but was not resolved. [2] elastic/elasticsearch-py@4352e56 [3] elastic/elasticsearch-py#701 PR: 229322 [1] Approved by: portmgr (blanket: framework compliance, runtime bugfix) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@499073 35697150-7ecd-e111-bb59-0022644237b5
kwm81
pushed a commit
to freebsd/freebsd-ports-gnome
that referenced
this issue
Apr 22, 2019
elasticsearch5 (this port) unnecessarily pins its urllib dependency to < 1.23, which blocks updating urllib3 to 1.24 [1]: ./textproc/py-elasticsearch5: setup.py: 'urllib3<1.23,>=1.21.1', The package had a history of issues/conflicts/bugs with the urllib3 dependency, ultimately resulting in the maximum version pin being removed [2]: elastic/elasticsearch-py#807 elastic/elasticsearch-py#667 elastic/elasticsearch-py#634 This commit backports that change, a functional noop and sweeping change in advance required for a urllib3 update, and adds TEST_DEPENDS and a test target to support rigorous and confident QA. Switching to GitHub sources was required as the PyPI sdist does not package tests. The packages tests all pass with/against urllib3 1.24 installed, with an intermittent and non-deterministic off-by-one failure in one test: FAIL: test_all_chunks_sent (test_elasticsearch.test_helpers.TestParallelBulk) The issue exists independent of urllib3 version. The flaky test issue was reported upstream [3], but was not resolved. [2] elastic/elasticsearch-py@4352e56 [3] elastic/elasticsearch-py#701 PR: 229322 [1] Approved by: portmgr (blanket: framework compliance, runtime bugfix)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the latest setup.py commit (f1267b5) the dependency on urllib3 was changed to 'urllib3<1.22,>=1.21.1'. The commit was titled "Fix urllib3 version to be compatible with requests". However, earlier that same day there had been a commit on requests (which is now in the latest release) to update the urllib3 dependency from 'urllib3>=1.21.1,<1.22' to 'urllib3>=1.21.1,<1.23' (psf/requests@8d1228c).
So the question is, since requests 2.18.2-2.18.4 is ok with urllib3 1.22, is elasticsearch ok with urllib3 1.22?
The text was updated successfully, but these errors were encountered: