update document should update with hash from as_indexed_json.

[dwkoogt]

update document should update with hash from as_indexed_json which could also contain derived attributes.
resolves #178
this also should resolve issues #88 #166 and #195

[ksaveras]

+1

[karmi]

@dwkoogt @xawiers Please see my comments in #178 -- I think we can close this issue.

[dwkoogt]

Well, #166 solves the problem of not using as_indexed_json to update the index. However, it is still limited to the attribute keys returned by changed_attriubtes which only watches changes in field attributes. If a custom key value (some derived value) is added within as_indexed_json, that key value change is not being watched. Hence if there's a change in that value, the change is not reflected in the index. Therefore my solution deletes the unchanged key-values instead of selecting the changed key-values. This will insure that any custom key value pair will be included in the update. This was my issue in #178.

[afn]

Can this be merged? The build failures appear to be spurious.

[afn]

Any update on this?

[Meekohi]

Hate to just +1 an issue, but this is the same problem I'm having as well and a little lost. Are there any work-arounds in the meantime for "forcing" a derived field to get sent along with ES updates?

[Meekohi]

Okay dug around in this more today and personally I like the @dwkoogt solution.

1. It is exactly the same if you don't use as_indexed_json
2. It is exactly the same if you use as_indexed_json but only with real attributes (i.e. that can be tracked in changed_attributes)
3. If you use computed attributes or methods in as_indexed_json (i.e. anything that can not be tracked in changed_attributes) it conservatively sends those along during updates.

In my opinion this is a pretty significant and sneaky bug that should be fixed.

@karmi "It certainly cannot be merged as is... We can absolutely have talk about the problem there."

Could you let us know what needs to be improved here to have it merged? I'd be willing to spend some time on this.

[karmi]

Hi @dwkoogt, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

[dwkoogt]

Hi @karmi, just updated my profile with the email address. thx.

[Meekohi]

Is this change for performance? Original version seemed more readable.

[dwkoogt]

My original change included with_indifferent_access method which is a rails extension which I removed here.

[dwkoogt]

Btw, I rebased on master and Travis is failing on this:
$ curl -sS https://snapshots.elastic.co/downloads/elasticsearch/elasticsearch-6.0.0-alpha1-SNAPSHOT.tar.gz | tar xz -C /tmp

[Meekohi]

@karmi any updates on what needs to happen here?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.