Partial update behavior

[zoer]

I got issue with localized fields(mongoid), after migrating from tire gem.

class Book
  include Mongoid::Document
  include Elasticsearch::Model
  include Elasticsearch::Model::Callbacks

  field :title, localized: true

  mapping do
    indexes :title, analyzer: "russian_morphology"
  end

  def as_indexed_json(opts={})
    {
      title: title
    }
  end
end

book = Book.create(title: "My book")
book.title = "My book 2"

book.changed_attributes # => {title: {ru: "My book 2"}}
book.as_indexed_json # => {title: "My book 2}

book.save
# Elasticsearch::Transport::Transport::Errors::BadRequest:
#       [400] {"error":"MapperParsingException[failed to parse [title]]; nested: ElasticsearchIllegalArgumentException[unknown property [ru]]; ","status":400}

Can we change this behavior a bit?

[karmi]

@zoer Thanks, looks legit, I'll need some time to look at it and be 100% sure what you're doing here. Ping me if I forget!

[karmi]

@zoer Out of curiosity, where does this: book.changed_attributes # => {title: {ru: "My book 2"}} come from? Ie. what makes the language "embedded" in the title?

[karmi]

@firien Yes, it will ignore alt_name, but that's a separate issue, and I believe issues/patches are already opened in this repository.

[zoer]

Sorry, bad example. That what I mean:

book = Book.create(title: "My book")
book.title = "My book 2"

book.save
# Elasticsearch::Transport::Transport::Errors::BadRequest:
#       [400] {"error":"MapperParsingException[failed to parse [title]]; nested: ElasticsearchIllegalArgumentException[unknown property [ru]]; ","status":400}

book.instance_variable_get(:@__changed_attributes) # => {title: {ru: "My book 2"}}
book.as_indexed_json # => {title: "My book 2}

[karmi]

@zoer I've actually found a simple way how to solve it, and that is "flipping the relationship" -- select data from as_indexed_json based on the keys of changed_attributes, not vice versa.

This means we don't need the complicate inject code.The test you've added pass. Can you verify that this works for your use case and we can close the issue?

[zoer]

Thx, that works.