update_document doesn't work on derived fields

[irsalmashhor]

Hi,

This is similar to issue #140

If I have the following model defined

 class Article < ActiveRecord::Base
  include Elasticsearch::Model

  def as_indexed_json(options = {})
    { description: self.description }
    { short_description: self.description[0...100] }
  end
end

Calling update_document will not update the short_description field because in the update_document method here:

self.as_indexed_json.select { |k,v| changed_attributes.keys.map(&:to_s).include? k.to_s }

It will only select attributes that are defined in the model

[arashkay]

+1

[arashkay]

In my case I have:

  settings do
    mappings do
      indexes :location, type: :geo_point
    end
  end

  def as_indexed_json(options={})
    as_json({ only: [:id, :age, :gender, :need_travel_buddy, :need_friendship, :need_relationship, :created_at], methods: [:location, :cached_connecting_to, :cached_connecting_from, :full_name] })
  end

And none of :location, :cached_connecting_to, :cached_connecting_from, :full_name are getting updated.

[karmi]

@irsalmashhor @tectual This should be solved by #166, please verify it and get back to me here or close the issue.

[wielinde]

Same situation for me (on 0.1.5). In my as_indexed_json I include return values of methods that combine or reverse attributes or associations of the model. These returned values are not reflected within @__changed_attributes which is used for checking if something has changed.

To put a different way: What as_indexed_json returns not necessarily has anything to do with the models attributes. It could be anything. So just checking for changed model attributes will never solve the issue.

When update_document is called and as_indexed_json is implemented in the model, you need to send the whole document to the elasticsearch server, I believe.

[Meekohi]

For anyone else searching -- As @wielinde points out, I don't think this issue is actually resolved by #166.

#182 looks like the new place to track the issue.