Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org.elasticsearch.xpack.esql.querydsl.query.SingleValueQueryTests.testNotMatchSome fails #105918

Closed
benwtrent opened this issue Mar 4, 2024 · 2 comments · Fixed by #105986
Closed

org.elasticsearch.xpack.esql.querydsl.query.SingleValueQueryTests.testNotMatchSome fails #105918

benwtrent opened this issue Mar 4, 2024 · 2 comments · Fixed by #105986
Assignees
@nik9000
Labels
:Analytics/ES|QL AKA ESQL blocker Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI

Comments

@benwtrent
Copy link
Member

CI Link

https://gradle-enterprise.elastic.co/s/4s2zmu3ptejvi

Repro line

./gradlew ':x-pack:plugin:esql:test' --tests "org.elasticsearch.xpack.esql.querydsl.query.SingleValueQueryTests.testNotMatchSome {p0=StandardSetup[fieldType=float, multivaluedField=true, empty=false, count=100]}" -Dtests.seed=12D140223DEBBFA8 -Dtests.locale=he -Dtests.timezone=Africa/Ceuta -Druntime.java=21

Does it reproduce?

Yes

Applicable branches

main, 8.13

Failure history

No response

Failure excerpt

org.elasticsearch.xpack.esql.querydsl.query.SingleValueQueryTests > testNotMatchSome {p0=StandardSetup[fieldType=float, multivaluedField=true, empty=false, count=100]} FAILED
--
  | java.lang.AssertionError:
  | Expected: <0>
  | but: was <2>
  | at __randomizedtesting.SeedInfo.seed([12D140223DEBBFA8:EBC472399B2907A8]:0)
  | at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
  | at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
  | at org.elasticsearch.test.ESTestCase.assertThat(ESTestCase.java:2119)
  | at org.elasticsearch.xpack.esql.querydsl.query.SingleValueQueryTests$StandardSetup.assertStats(SingleValueQueryTests.java:316)
  | at org.elasticsearch.xpack.esql.querydsl.query.SingleValueQueryTests.testCase(SingleValueQueryTests.java:218)
  | at org.elasticsearch.xpack.esql.querydsl.query.SingleValueQueryTests.testNotMatchSome(SingleValueQueryTests.java:142)
@benwtrent benwtrent added >test-failure Triaged test failures from CI :Analytics/ES|QL AKA ESQL labels Mar 4, 2024
@elasticsearchmachine elasticsearchmachine added blocker Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Mar 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@benwtrent
Copy link
Member Author

There are many other repo lines with various other inputs that cause this test to fail, but I didn't want to copy 20+ of them.

Seems to happen on any fieldType & empty true or false.

benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Mar 4, 2024
@benwtrent
Test mute for elastic#105918
e2cda88
@benwtrent benwtrent mentioned this issue Mar 4, 2024
Merged
benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Mar 4, 2024
@benwtrent
Test mute for elastic#105918
61ec4b5
@benwtrent benwtrent mentioned this issue Mar 4, 2024
Merged
@nik9000 nik9000 self-assigned this Mar 4, 2024
elasticsearchmachine pushed a commit that referenced this issue Mar 4, 2024
@benwtrent
Test mute for #105918 (#105919)
89786f5 
mute for: #105918
elasticsearchmachine pushed a commit that referenced this issue Mar 4, 2024
@benwtrent
Test mute for #105918 (#105920)
352850b 
mute for: #105918
@benwtrent benwtrent mentioned this issue Mar 5, 2024
Closed
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Mar 5, 2024
@nik9000
ESQL: fix single valued query tests
b18c669 
In some cases the tests for our lucene query that makes sure a field is
single-valued was asserting incorrect things about the stats that come
from the query. That was failing the test from time to time. This fixes
the assertion in those cases.

Closes elastic#105918
@nik9000 nik9000 mentioned this issue Mar 5, 2024
Merged
nik9000 added a commit that referenced this issue Mar 5, 2024
@nik9000
ESQL: fix single valued query tests (#105986)
71ffd35 
In some cases the tests for our lucene query that makes sure a field is
single-valued was asserting incorrect things about the stats that come
from the query. That was failing the test from time to time. This fixes
the assertion in those cases.

Closes #105918
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Mar 5, 2024
@nik9000
ESQL: fix single valued query tests (elastic#105986)
e8e5244 
In some cases the tests for our lucene query that makes sure a field is
single-valued was asserting incorrect things about the stats that come
from the query. That was failing the test from time to time. This fixes
the assertion in those cases.

Closes elastic#105918
@nik9000 nik9000 mentioned this issue Mar 5, 2024
Merged
elasticsearchmachine pushed a commit that referenced this issue Mar 5, 2024
@nik9000
ESQL: fix single valued query tests (backport of #105986) (#105995)
86719a3 
* ESQL: fix single valued query tests (#105986)

In some cases the tests for our lucene query that makes sure a field is
single-valued was asserting incorrect things about the stats that come
from the query. That was failing the test from time to time. This fixes
the assertion in those cases.

Closes #105918

* ESQL: Reenable svq tests

We fixed the test failure in #105986 but this snuck in.

Closes #105952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
:Analytics/ES|QL AKA ESQL blocker Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESQL: fix single valued query tests nik9000/elasticsearch
3 participants
@nik9000 @benwtrent @elasticsearchmachine