Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] SingleValueQueryTests testMatchSome {p0=StandardSetup[fieldType=double, multivaluedField=false, empty=false, count=100]} failing #105952

Closed
benwtrent opened this issue Mar 5, 2024 · 2 comments · Fixed by #105996
Assignees
Labels
:Analytics/ES|QL AKA ESQL blocker Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI

Comments

@benwtrent
Copy link
Member

benwtrent commented Mar 5, 2024

Pretty much all of testMatchSome fails. I suspect same cause as: #105918

Build scan:
https://gradle-enterprise.elastic.co/s/g6ezzkpnkrd42/tests/:x-pack:plugin:esql:test/org.elasticsearch.xpack.esql.querydsl.query.SingleValueQueryTests/testMatchSome%20%7Bp0=StandardSetup%5BfieldType=double,%20multivaluedField=false,%20empty=false,%20count=100%5D%7D

Reproduction line:

./gradlew ':x-pack:plugin:esql:test' --tests "org.elasticsearch.xpack.esql.querydsl.query.SingleValueQueryTests.testMatchSome {p0=StandardSetup[fieldType=double, multivaluedField=false, empty=false, count=100]}" -Dtests.seed=BF749916325C715B -Dtests.locale=es-NI -Dtests.timezone=America/Jamaica -Druntime.java=21

Applicable branches:
main, 8.13

Reproduces locally?:
Yes

Failure history:
Failure dashboard for org.elasticsearch.xpack.esql.querydsl.query.SingleValueQueryTests#testMatchSome {p0=StandardSetup[fieldType=double, multivaluedField=false, empty=false, count=100]}

Failure excerpt:

java.lang.AssertionError: 
Expected: <0>
     but: was <1>

  at __randomizedtesting.SeedInfo.seed([BF749916325C715B:6BD20D5D78199F88]:0)
  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
  at org.elasticsearch.test.ESTestCase.assertThat(ESTestCase.java:2120)
  at org.elasticsearch.xpack.esql.querydsl.query.SingleValueQueryTests.testCase(SingleValueQueryTests.java:221)
  at org.elasticsearch.xpack.esql.querydsl.query.SingleValueQueryTests.testMatchSome(SingleValueQueryTests.java:82)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1583)

@benwtrent benwtrent added :Analytics/ES|QL AKA ESQL >test-failure Triaged test failures from CI labels Mar 5, 2024
@elasticsearchmachine elasticsearchmachine added blocker Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Mar 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Mar 5, 2024
benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Mar 5, 2024
elasticsearchmachine pushed a commit that referenced this issue Mar 5, 2024
elasticsearchmachine pushed a commit that referenced this issue Mar 5, 2024
@nik9000 nik9000 self-assigned this Mar 5, 2024
@nik9000
Copy link
Member

nik9000 commented Mar 5, 2024

I believe I fixed this in #105986 but I'll have a look.

nik9000 added a commit to nik9000/elasticsearch that referenced this issue Mar 5, 2024
We fixed the test failure in elastic#105986 but this snuck in.

Closes elastic#105952
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Mar 5, 2024
We fixed the test failure in elastic#105986 but this snuck in.

Closes elastic#105952
elasticsearchmachine pushed a commit that referenced this issue Mar 5, 2024
* ESQL: fix single valued query tests (#105986)

In some cases the tests for our lucene query that makes sure a field is
single-valued was asserting incorrect things about the stats that come
from the query. That was failing the test from time to time. This fixes
the assertion in those cases.

Closes #105918

* ESQL: Reenable svq tests

We fixed the test failure in #105986 but this snuck in.

Closes #105952
elasticsearchmachine pushed a commit that referenced this issue Mar 5, 2024
We fixed the test failure in #105986 but this snuck in.

Closes #105952
jedrazb pushed a commit to jedrazb/elasticsearch that referenced this issue Mar 6, 2024
jedrazb pushed a commit to jedrazb/elasticsearch that referenced this issue Mar 6, 2024
We fixed the test failure in elastic#105986 but this snuck in.

Closes elastic#105952
gmarouli pushed a commit to gmarouli/elasticsearch that referenced this issue Mar 6, 2024
We fixed the test failure in elastic#105986 but this snuck in.

Closes elastic#105952
fang-xing-esql pushed a commit to fang-xing-esql/Elasticsearch that referenced this issue Mar 8, 2024
fang-xing-esql pushed a commit to fang-xing-esql/Elasticsearch that referenced this issue Mar 8, 2024
We fixed the test failure in elastic#105986 but this snuck in.

Closes elastic#105952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL blocker Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants