Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: fix single valued query tests (backport of #105986) #105995

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Mar 5, 2024

In some cases the tests for our lucene query that makes sure a field is
single-valued was asserting incorrect things about the stats that come
from the query. That was failing the test from time to time. This fixes
the assertion in those cases.

Closes #105918
Closes #105952

In some cases the tests for our lucene query that makes sure a field is
single-valued was asserting incorrect things about the stats that come
from the query. That was failing the test from time to time. This fixes
the assertion in those cases.

Closes elastic#105918
We fixed the test failure in elastic#105986 but this snuck in.

Closes elastic#105952
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests backport :Analytics/ES|QL AKA ESQL v8.13.0 labels Mar 5, 2024
@nik9000 nik9000 added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 5, 2024
@elasticsearchmachine elasticsearchmachine merged commit 86719a3 into elastic:8.13 Mar 5, 2024
14 checks passed
@nik9000 nik9000 deleted the fix_105952_8_13 branch March 5, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >test Issues or PRs that are addressing/adding tests v8.13.0 v8.13.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants