Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove URL from PluginManager #12896

Closed
dakrone opened this issue Aug 14, 2015 · 3 comments
Closed

Remove URL from PluginManager #12896

dakrone opened this issue Aug 14, 2015 · 3 comments
Labels
:Core/Infra/Plugins Plugin API and infrastructure >enhancement good first issue low hanging fruit help wanted adoptme

Comments

@dakrone
Copy link
Member

dakrone commented Aug 14, 2015

We should be using URI instead.

It'd be great to eventually get new URL(...) in the forbidden APIs also.

@rjernst
Copy link
Member

rjernst commented Aug 14, 2015

+1

@clintongormley clintongormley added help wanted adoptme :Core/Infra/Plugins Plugin API and infrastructure good first issue low hanging fruit labels Jan 28, 2016
@rjernst
Copy link
Member

rjernst commented Mar 13, 2017

The plugin manager was completely rewritten since creating this issue. It still uses new URL, but only in the case that a URL is passed in (in which case the plugin id is not a builtin plugin or a maven identifier). We need URL because we need to open a connection; URI only has information about the URI, but you still need to call toURL() to get something that can open a connection.

@rjernst rjernst closed this as completed Mar 13, 2017
@dakrone
Copy link
Member Author

dakrone commented Mar 13, 2017

+1, thanks for closing this Ryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Plugins Plugin API and infrastructure >enhancement good first issue low hanging fruit help wanted adoptme
Projects
None yet
Development

No branches or pull requests

3 participants