Remove cloud.account and cloud.key settings
#12978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
dadoonet
added a commit
to dadoonet/elasticsearch
that referenced
this pull request
Jul 20, 2016
We have a bug described in elastic#19445 where a user wants to define specific key/secret for EC2 and S3: ``` cloud: aws: s3: access_key: xxxxxxxxxxxx secret_key: XXxxxxxXxxxxXxxxXxXxXxxx ec2: access_key: yyyyyyyyyyyyy secret_key: yyyYyyyyyYyyyyYyyyYyYyY ``` This is documented and should work. This commit fixes that and adds a test. BTW, while working on this issue, I discovered that the removal effort made in elastic#12978 has been reintroduced by mistake in fe74219. So I removed this again. Closes elastic#19445
clintongormley
added
:Distributed/Snapshot/Restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we are going to remove it, put a quick PR
closes #12809