[WIP] Remove repositories.s3 settings and deprecated settings #23276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is labeled as work in progress. Do not merge it as is.
Global repositories settings we were able to set in elasticsearch config file under
repositories.s3
name space are removed (deprecate in 5.x). This includes
repositories.s3.bucket
,repositories.s3.server_side_encryption
,repositories.s3.buffer_size
,repositories.s3.max_retries
,repositories.s3.use_throttle_retries
,repositories.s3.chunk_size
,repositories.s3.compress
,repositories.s3.storage_class
,repositories.s3.canned_acl
,repositories.s3.base_path
andrepositories.s3.path_style_access
.We must set those settings per repository instead. Respectively
bucket
,server_side_encryption
,buffer_size
,max_retries
,use_throttle_retries
,chunk_size
,compress
,storage_class
,canned_acl
,base_path
andpath_style_access
.Related to #22800.
S3 plugin is now using named configurations. We basically define all the S3 clients we want to use by naming
them under
s3.client.xxx
prefix wherexxx
is the named configuration (usedefault
as the name if you want to haveone applied by default).
As a consequence, the following settings have been removed:
cloud.aws.access_key
,cloud.aws.secret_key
,cloud.aws.protocol
,cloud.aws.proxy.host
,cloud.aws.proxy.port
,cloud.aws.proxy.username
,cloud.aws.proxy.password
,cloud.aws.signer
,cloud.aws.read_timeout
.Also their S3 specific equivalent have been removed:
cloud.aws.s3.access_key
,cloud.aws.s3.secret_key
,cloud.aws.s3.protocol
,cloud.aws.s3.proxy.host
,cloud.aws.s3.proxy.port
,cloud.aws.s3.proxy.username
,cloud.aws.s3.proxy.password
,cloud.aws.s3.signer
,cloud.aws.s3.read_timeout
.Also
repositories.s3.access_key
,repositories.s3.secret_key
,repositories.s3.endpoint
andrepositories.s3.protocol
.This also removes Signer as discussed in #22599. It will be marked as deprecated in 5.x branch.
Still to do:
s3.client.default.access_key
ands3.client.default.secret_key
in the vault or to simulate it.