Throw exception in scroll requests using from
#26235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `from` search parameter cannot really be used in scrolled searches. This commit adds a check for this case to the SearchRequest#validate() method so we can reported it as an error rather than silently ignoring it. Closes elastic#9373
s1monw
approved these changes
Aug 16, 2017
|
@s1monw thanks, I also had to adapt a failing rest test that used "from" in a scroll. Maybe you or @nik9000 (who seems to have added it) can recheck that this change is okay. |
nik9000
approved these changes
Aug 17, 2017
|
@s1monw I'll merge this into 7.0 and add a migration note and add the breaking label in a separate PR for 6.0/6.x, is that okay with you? |
cbuescher
added a commit
that referenced
this pull request
Aug 21, 2017
cbuescher
added a commit
that referenced
this pull request
Aug 21, 2017
clintongormley
added
the
:Search/Search
hub-cap
added a commit
to hub-cap/elasticsearch
that referenced
this pull request
Aug 28, 2019
This commit builds on elastic#26235, and adds the same validation to the builder so that it will throw an exception when setting a scroll on a request that has from set. Relates elastic#9373 Closes elastic#44493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the discussion in #9373, the
fromsearch parameter cannot really be used with scrolled searches.This commit adds a check for this case to the SearchRequest#validate() method so we can reported it as an
error rather than silently ignoring it.
Closes #9373