Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to repository-s3 plugin creating an S3 bucket #30910

Closed
maximshd opened this issue May 28, 2018 · 4 comments
Closed

Remove reference to repository-s3 plugin creating an S3 bucket #30910

maximshd opened this issue May 28, 2018 · 4 comments
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes help wanted adoptme

Comments

@maximshd
Copy link

Docs mention that repository-s3 plugin is able to create AWS S3 bucket when it doesn't exist (and appropriate IAM permissions were added).
But it just fails without any validation according to this part of a code:
. SocketAccess.doPrivilegedVoid(() -> { if (client.doesBucketExist(bucket) == false) { throw new IllegalArgumentException("The bucket [" + bucket + "] does not exist. Please create it before " + " creating an s3 snapshot repository backed by it."); } });

Previously cloud-aws plugin was able to create bucket.
Is it expected for repository-s3 plugin?
Is it possible to change documentation accordingly to the plugin behavior or add possibility to create S3 bucket by ES/plugin means?

Thanks!

@dadoonet
Copy link
Member

In doc you linked to I can see

The bucket needs to exist to register a repository for snapshots. If you did not create the bucket then the repository registration will fail.

Which part of the doc mentions something else?

@maximshd
Copy link
Author

Hi, @dadoonet ,

"If you want Elasticsearch to create the bucket instead, you can add the permission to create a specific bucket like this:"

But seems like ES will not try to create any bucket in any cases.

@dadoonet dadoonet added the >docs General docs changes label May 29, 2018
@dadoonet
Copy link
Member

Ha right. That's a leftover IMO. We should remove that part.

@dadoonet dadoonet added the help wanted adoptme label May 29, 2018
@DaveCTurner DaveCTurner changed the title repository-s3 plugin fails with exception when S3 bucket doesn't exist Remove references to repository-s3 plugin creating an S3 bucket May 29, 2018
@DaveCTurner DaveCTurner added the :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs label May 29, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@DaveCTurner DaveCTurner changed the title Remove references to repository-s3 plugin creating an S3 bucket Remove reference to repository-s3 plugin creating an S3 bucket May 29, 2018
tlrx added a commit to tlrx/elasticsearch that referenced this issue Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes help wanted adoptme
Projects
None yet
Development

No branches or pull requests

4 participants