Releasable bytes output + use in transport / translog #5691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create a new releasable bytes output, that can be recycled, and use it in netty and the translog, 2 areas where the recycling will help nicely. Note, opted for statically typed enforced releasble bytes output, to make sure people take the extra care to control when the bytes reference are released. Also, the mock page/array classes were fixed to not take into account potential recycling going during teardown, for example, on a shared cluster ping requests still happen, so recycling happen actively during teardown.
| if (!failures.isEmpty()) { | ||
| final Object cause = failures.entrySet().iterator().next().getValue(); | ||
| throw new RuntimeException(failures.size() + " arrays have not been released", cause instanceof Throwable ? (Throwable) cause : null); | ||
| } |
There was a problem hiding this comment.
I think this can be made easier to read and more concise using set operations like retainAll?
There was a problem hiding this comment.
And could we extract the logic to an utility method so that both MockBigArrays and MockPageCacheRecycler can use it?
|
This looks good to me, I left comments but they are more about cosmetics. |
- move NetworkUtils change, do it in separate change - simplify set checks - didn't refactor to a common class, It think the logic is small enough to not warrant it for now
kimchy
added a commit
that referenced
this pull request
Apr 6, 2014
create a new releasable bytes output, that can be recycled, and use it in netty and the translog, 2 areas where the recycling will help nicely. Note, opted for statically typed enforced releasble bytes output, to make sure people take the extra care to control when the bytes reference are released. Also, the mock page/array classes were fixed to not take into account potential recycling going during teardown, for example, on a shared cluster ping requests still happen, so recycling happen actively during teardown. closes #5691
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create a new releasable bytes output, that can be recycled, and use it in netty and the translog, 2 areas where the recycling will help nicely.
Note, opted for statically typed enforced releasble bytes output, to make sure people take the extra care to control when the bytes reference are released.
Also, the mock page/array classes were fixed to not take into account potential recycling going during teardown, for example, on a shared cluster ping requests still happen, so recycling happen actively during teardown.