[ENGINE] Upgrade 3.x segments on engine startup #9899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikemccand can you take a look |
| @@ -724,4 +726,45 @@ public void delete() { | |||
| throw new UnsupportedOperationException("This IndexCommit does not support deletions"); | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Retruns <code>true</code> iff the store contains an index that contains segments that where | |||
There was a problem hiding this comment.
Retruns -> Returns
where -> were
|
@mikemccand @kimchy pushed a new commit |
| .setMergePolicy(NoMergePolicy.INSTANCE) | ||
| .setOpenMode(IndexWriterConfig.OpenMode.APPEND))) { | ||
| Map<String, String> commitData = iw.getCommitData(); | ||
| iw.setCommitData(commitData); |
There was a problem hiding this comment.
Maybe add a comment that you do this to trick IW into committing when it thinks nothing changed :)
|
Left 2 minor comments else LGTM. |
|
cool thanks, I beefed up the test a bit and applied the feedback |
|
LGTM |
Upgrading 3.x segments have been proven to be error prone especially when it get's to concurrency. Bugs like LUCENE-6287 cause index corrupting when segmetns are upgraded concurrently to a merge. To play safe this commit upgrades pending segments without merging etc. before the engine gets started up.
s1monw
force-pushed
the
upgrade_index_on_engine_startup
branch
from
b8c1af3
to
f5b1ba4
Compare
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading 3.x segments have been proven to be error prone especially when it get's to
concurrency. Bugs like LUCENE-6287 cause index corrupting when segmetns are upgraded
concurrently to a merge. To play safe this commit upgrades pending segments without
merging etc. before the engine gets started up.